Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decomission of scripts/ci #1760

Merged
merged 7 commits into from
Jul 31, 2023
Merged

Decomission of scripts/ci #1760

merged 7 commits into from
Jul 31, 2023

Conversation

ia
Copy link
Collaborator

@ia ia commented Jul 27, 2023

  • Please check if the PR fulfills these requirements
  • The changes have been tested locally
  • There are no breaking changes
  • What kind of change does this PR introduce?
    Remove out-of-dated files.

  • What is the current behavior?
    Directory scripts/ci contains two md5 files which, as far as I understand, some legacy files from the previous way of preparing env & compiling firmware (probably, sums used to make sure that the proper toolchains are used) and one shell script which could be easily replaced by make target for unification of the build system.

  • What is the new behavior (if this is a feature change)?

  • scripts/ci is removed completely
  • build-all target implemented in the top-level Makefile
  • call of buildAll.sh is replaced by make build-all
  • optionally, OUT environmental variable can be provided to set another directory for output, i.e., if for some reason someone would want to copy compiled binaries to scripts/ci/artefacts then just use make build-all OUT=scripts/ci/artefacts or OUT=scripts/ci/artefacts ./scripts/deploy.sh build
  • basic possible combinations of calling build-all in updated manner have been tested locally successfully
  • default output directory (instead of old scripts/ci/artefacts) is OUT directory right in the IronOS root project directory
  • Other information:
    Since I couldn't find any hard-coded values regarding scripts/ci/artefacts I decided to pick more easy-to-find place as default which is OUT directory currently. And for the same reason I guess it shouldn't break anything but bring a bit of more tidiness to files, directory structure & maintainability. Therefore, after this patch there will be only two make files (Makefile & source/Makefile) and only two shell scripts (scripts/deploy.sh & source/build.sh)

Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
@ia ia requested a review from Ralim July 28, 2023 10:13
@Ralim Ralim merged commit e0f373a into Ralim:dev Jul 31, 2023
@ia ia deleted the make-buildall branch July 31, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants