Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cosmetic code style refactoring: add enum for screen orientation & define for OLED state #1732

Merged
merged 10 commits into from
Jul 5, 2023

Conversation

ia
Copy link
Collaborator

@ia ia commented Jul 4, 2023

  • Please check if the PR fulfills these requirements
  • The changes have been tested locally
  • There are no breaking changes
  • What kind of change does this PR introduce?
    Cosmetic code style refactoring. Main changes:

    • add enum for screen orientation
    • add define for OLED state
    • add markings for #endifs in files which have been updated due to implemented refactoring
    • plus some intuitive unification including following non-formal rules such as:
      • add empty new line between blocks of function/method implementations
      • remove empty new first line inside of function/method (since most functions/methods don't have it)
        And so on.
  • What is the current behavior?

  • What is the new behavior (if this is a feature change)?

  • Other information:
    It's more like experiment than anything else and I hope I didn't mess much with preferable style but I just tried to unify code style in files which I updated anyway. Can't wait for feedback.

Made builds successfully and tested firmware on TS80P but there shouldn't be any difference since there is no any functionality update.

Copy link
Owner

@Ralim Ralim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me.
You really like annotating the #endif dont you? Doesnt your IDE do that for you 😁

@Ralim Ralim merged commit cbde61e into Ralim:dev Jul 5, 2023
@ia
Copy link
Collaborator Author

ia commented Jul 5, 2023

You really like annotating the #endif dont you?

Had a couple of problems in the past due to not having them. ;)

Doesnt your IDE do that for you 😁

Touche`! :D
Sometimes it's just super-convenient visually to have them when you only want to check something very briefly through simple editor/online code navigation.

@ia ia deleted the enum-screen-t branch July 11, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants