-
-
Notifications
You must be signed in to change notification settings - Fork 728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Root directory content refactoring #1725
Conversation
…tate README to main README; - replace separate root scripts build.sh and start_dev.sh by root Makefile; - make Scripts directory and move there: flash_ts100_linux.sh script, ci/ directory, dockerfile, LICENSE_RELEASE, and PULL_REQUEST_TEMPLATE; - reconfigure build & deploy scripts according to changes
Oh, and |
Just checked that content of the |
Makefile
Outdated
|
||
# command for docker-compose tool | ||
ifndef DOCKER_COMPOSE | ||
DOCKER_COMPOSE:=docker-compose |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While we are here, can we test for docker-compose
and if its not here fall back to docker compose
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thoughtful suggestion. No problem, I will test & check how to make it in a more or less reliable way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hia,
Thank you for the changes; I agree with all of this. Except really want to keep the single script to get into dev container part of the workflow. We shouldn't_ rely on users having make on their system.
A few questions while I will be working on proposed changes.
|
Prefer to keep it; would rather verbosity than yet more tickets
That file has been here since before you had any customisation control lol. This can likely be refactored into the
Honestly no idea, personally happy to ship this and review (and fix) if it breaks. You have done about all I would do tbh
I believe that for security reasons you cant walk the tree above where you start. The convention is that the |
No problem at all! Just wanted to make sure since we update it anyway.
Oh, actually you're right! I should ask google/look for github documentation first before wasting your time with this simple question ;)
Deal!
Just like I thought based on the information which I could find. Thanks. |
…h script, move github templates from top-level dir to .github, organize files inside Development Resources
UPDATE Main locations/files modifications:
What have been tested:
Two main concerns are:
But I guess these two will be fixed once we discover them. :) |
Oh, I see some |
Another one testing result update: I can confirm that command |
Just to clarify: duplicating the functions of
It could be logical to make them rely one on each other (for example, calling |
Wiki documentation has been refreshed & updated as well. Ironically, but despite the fact that wiki is managed by git repo on github, there is no way to make a pull request using web interface AFAIK. So, repo with some updates is here and the way how it will be looking is here. The original repo
Yes, I know that ReadTheDocs online docs getting more often updates and probably will be the only one source of documentation soon, but since wiki is still there [yet] & it's "googl-able", I thought it should be updated as well just in case. |
I'm 100% happy with this given the following: Ergo, I'm going to merge this ^_^; suuper thankful for all of this work btw. My eventual goal is to fully remove the wiki if I can and just point everyone to do the read-the-docs. |
Have applied wiki updates as well (fwiw) |
Really? But
Since I'm the initiator for that, I don't mind to be responsible for top-level
Thank you for accepting my patches. 🙏
I agree that there is no much of the point to have two different docs "engines" for the same project.
I think I have some idea...
I will add this to my todo list. When I have time & fresh head, I will try to look through content from wiki very carefully again and if there will be something relevant worth saving info, then I will be happy to move it to Oh, and it's always just a pleasure to interact with you & others in comments for PRs & Issues of this project. Thanks a lot for such communal hospitality especially for new comers & newbie contributors. 🥹 |
Could you, please, make just only one more wiki merge? |
Wiki updated |
What kind of change does this PR introduce?
Rearrangement of the project root directory.
What is the current behavior?
When a person who is curious about the project, downloads and/or opens it on github, there are a lot of stockpiled files in a root directory for different purposes/automation/deploy/documentation tasks.
What is the new behavior (if this is a feature change)?
Since root directory is a store front of a project, such amazing project as this one deserves a bit more tidy main entrance in my humble opinion.
Main locations/files modifications:
Bootup Logo/README.md
toREADME.md
build.sh
&start_dev.sh
byMakefile
Flashing
one file directory to newly createdScripts
directoryDockerfile
toScripts/IronOS.Dockerfile
ci
directory,mkdocs.yml
,LICENSE_RELEASE
, andPULL_REQUEST_TEMPLATE
insideScripts
directoryMakefile
can run docker-related commands, generate docs and pass-through targets forsource/
directoryPartially it's like putting under the rug files which must be with the project, but they don't have to be in direct sight.
What have been tested successfully:
make docker-shell
make docker-build
make docs
What haven't been tested:
make docs
for RtD online location (not sure how better to test it - to make pull request arounddocs
branch?)Probably section about
Bootup Logo
can be safely removed fromREADME.md
completely since there is mention ofBootup Logo
feature in a feature list with link to official documentation.As always, let me know what you think. Thanks for any feedback.