source/Makefile: add HOST_PYTHON, extend clean target, remove -.d generation #1701
Conversation
…ty of environment setup / extend clean target to make source directory as new / rename -.d autogenerated temp file
There was a problem hiding this comment.
Well I'm rather concerned anyone is running python 3.7 or older now (given <3.7 is already dead, and 3.7 is EOL in less than two weeks). But I see no issue with a python path. :)
However, please dont remove the hexfile folder, the intent is explicit for it to remain to make it easier when your reflashing a Miniware iron a stack of times.
source/Makefile
Outdated
| rm -Rf Core/Gen | ||
| rm -Rf $(OUTPUT_DIR_BASE) | ||
| rm -Rf $(HEXFILE_DIR)/* | ||
| rm -Rf $(HEXFILE_DIR) |
There was a problem hiding this comment.
Please dont rm the Hexfile folder if we can, it makes it far more annoying as it means file mangers will kick you out (as the folder is gone) or a terminal in the folder will have a broken path.
There was a problem hiding this comment.
Aaaaha! I haven't thought that it may be useful, sorry-sorry. 😰 Will re-do patch as soon as I can. 👌
There was a problem hiding this comment.
Oh, wait a minute... I sincerely sorry to bother you, just expressing some suggestion before updating PR - how about adding another one target, something like this right next to clean target:
mrproper / clean-all: clean
rmdir $(HEXFILE_DIR)
Just curious what do you think about such approach? Thanks.
Update: it's not my stubbornness but tidiness - I just think that it's a good approach to have additional clean[] target cleaning source tree to default state, that's it.
There was a problem hiding this comment.
clean-all would be totally fine by me :) 😁 🤗
I totally get you on having a full cleanup; I probably should throw a comment on it as to why that folder gets left hanging around. It was deliberate, but probably not obvious until one does a few device bring ups 🤣
|
Oh, and the odd file never bothered me; but good to have that resolved 😁 |
|
|
Probably swap |
No problem. Was debating over the target name anyway myself. Thanks for resolving. 🤭 |
|
Thank you for the help with this 🙇🏼 |
It's my pleasure & honor to finally commit back at least something useful for this amazingly useful and incredibly awesome project. 🙏 |
Set of changes:
HOST_PYTHONvariable for flexibility of environment setupcleantarget to make source directory as new-.dautogenerated temp fileHOST_PYTHONvariable for flexibility of environment setup.Without patch on some environments:
Finalhas been implemented inPythonstarting fromv3.8. Some systems providePython 3.8but not aspython3. So instead of messing with environment, this patch implements variable for providing custom version. After the patch:In addition, this patch extends
cleantarget to make source dir as new.Also, this patch renames hard-to-remove
-.dtemp file which seems not to be used during compilation but generated byFrom
man gcc(for-MDoption) (I had no idea about this myself):Since we have input as
stdin, hence we get-.din our directories like a gum glued to shoes. By adding-MF Core/Gen/macros.tmptemp file will be generated where it should.