Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update translation_RO.json #1632

Merged
merged 4 commits into from
Mar 26, 2023

Conversation

discip
Copy link
Collaborator

@discip discip commented Mar 20, 2023

Fortunately there is a way to use diacritics in translation_RO. 😊

@mobycl1ck
@cipyyy
@sandmanRO

@discip discip enabled auto-merge March 20, 2023 21:09
@discip discip requested a review from Ralim March 20, 2023 21:10
@sandmanRO
Copy link

Hello @discip, I had no doubt that eventually you will get this sorted out. Only I noticed a small typo in the translation_RO.json. At line 172 ("description": "Clipeţte temperatura după oprirea încălzirii, în timp ce vârful este încă fierbinte"), the first word of the translation ("Clipeţte") is misspelled. It should be "Clipeşte". The word is the translation for blinking.

@discip
Copy link
Collaborator Author

discip commented Mar 21, 2023

@sandmanRO
Fixed!

The original file came from @mobycl1ck.
And I noticed exactly that difference, but as he changed it, I believed this was correct. 😅

Btw:
Have you already tested it on your device?

@sandmanRO
Copy link

Hello @discip, I haven't tested the new translation as on my TS100s I have a custom version of the firmware that is not so fancy as the IronOS (the text is hardwired in the code and it can not be easily changed as in the IronOS).

@discip
Copy link
Collaborator Author

discip commented Mar 21, 2023

@sandmanRO
No problem at all, just curious how a native speaker would judge the result. 😊

@mobycl1ck
Copy link
Contributor

Helo folks, hectic week at work, saw the changes being merged and after all the corrections being made. RO_translation is finished and has the right form and shape, as in use of diacritics and other details.

@discip discip merged commit fdff919 into Ralim:dev Mar 26, 2023
@discip discip deleted the fixing-translation_RO-using-diacritics branch March 26, 2023 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants