Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Variables to Dockerfile #1597

Merged
merged 7 commits into from
Apr 1, 2023
Merged

Conversation

slycordinator
Copy link
Contributor

  • Please check if the PR fulfills these requirements
  • [] The changes have been tested locally
  • There are no breaking changes
  • What kind of change does this PR introduce?
    This change adds variables for the different packages for the docker build.
    It adds variables for the compiler, python, misc, dev, and pip packages to be installed

This separates each of the package categories as well as allows for quickly editing if any packages change. For instance, if alpine were to change the name of a package, replace it with a different one, or if the docker were changed to use a different base distro.

  • What is the current behavior?
    There's nothing wrong with the current behavior.

  • What is the new behavior (if this is a feature change)?
    The behavior stays the same with this change; this change just makes for easier maintenance.

  • Other information:
    This change has the variables in question specified as "ARG". Originally, I used "ENV".
    I made it use ARG, because as I read "ENV" variables are environment variables for the final running container, whereas ARG variables are meant to be used for building a container.

@Ralim
Copy link
Owner

Ralim commented Feb 24, 2023

Hia, can you update this against dev as there are conflicts at the moment.

Updated change to match -dev
@slycordinator
Copy link
Contributor Author

I've updated it to match dev.

black is now in the APK_PYTHON variable and is going to be installed through APK as in the -dev-branch version of the "Dockerfile".

@slycordinator slycordinator reopened this Feb 24, 2023
@Ralim Ralim enabled auto-merge (squash) April 1, 2023 03:03
@Ralim Ralim merged commit dcfb650 into Ralim:dev Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants