Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only send on display change #1464

Merged
merged 2 commits into from
Nov 7, 2022
Merged

Only send on display change #1464

merged 2 commits into from
Nov 7, 2022

Conversation

Ralim
Copy link
Owner

@Ralim Ralim commented Nov 6, 2022

Using a small checksum on the OLED update; to only send the screen contents data.
This is to reduce activity on the I2C bus when we dont need to.

@Ralim
Copy link
Owner Author

Ralim commented Nov 6, 2022

Would love some extra testing for this. I do not expect any adverse effects. Seems to be totally fine on my devices here.
Expecting no change to occur.
@river-b [PinecilV1/V2] & @discip [Whatever you have on hand]

So that we backoff if OLED is busy

Update OLED.hpp
@Ralim Ralim force-pushed the only-send-screen-on-change branch from 9deaa26 to 80e7ab3 Compare November 6, 2022 11:54
@Ralim
Copy link
Owner Author

Ralim commented Nov 6, 2022

Slipping in extra tweak to delay after changing the display on/off state. As some displays want this; so trying it out.

@Ralim Ralim marked this pull request as ready for review November 6, 2022 21:59
@River-Mochi
Copy link
Contributor

I have other people willing to test also.

@Ralim Ralim merged commit 1444f94 into dev Nov 7, 2022
@Ralim Ralim deleted the only-send-screen-on-change branch November 7, 2022 09:08
@discip
Copy link
Collaborator

discip commented Nov 7, 2022

@Ralim
Sorry for being late.

I tested this with the TS80P and noticed, that CJC clibration does not work as intended.
I do not know if this has to do anything with this commit, but will investigate further to find out.

Apart from that everything seems to work just fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants