Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update translation_RO.json #1443

Merged
merged 5 commits into from
Oct 27, 2022
Merged

Update translation_RO.json #1443

merged 5 commits into from
Oct 27, 2022

Conversation

discip
Copy link
Collaborator

@discip discip commented Oct 24, 2022

@cipyyy
Your changes should be implemented with this PR.
Unfortunately 2 specific letters (ț and ș) could not be used, remember this was discussed when this language pack was about to be implemented @sandmanRO suggested to leave these out (#1056).

@sandmanRO
Copy link

Hello @discip, hello @cipyyy,
@cipyyy, if I may suggest, when you do the Romanian translation try to stick only with the characters from the basic set (that is no diacritics). We both know that the lack of diacritics is tolerated in Romanian writing as their absence does not change the meaning of the words. The letters with diacritics come from extended character sets, and they do not always match and this could lead to all sort of issues when building the firmware.

Translations/translation_RO.json Outdated Show resolved Hide resolved
Translations/translation_RO.json Outdated Show resolved Hide resolved
@Ralim Ralim merged commit 5b6cb09 into Ralim:dev Oct 27, 2022
@discip discip deleted the patch-2 branch October 28, 2022 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants