-
-
Notifications
You must be signed in to change notification settings - Fork 731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
moved_reset_settings #1401
moved_reset_settings #1401
Conversation
Since in most appliances the reset option is placed somewhere near the end, this might be the way to go for IronOS as well. Fixed some inconsistencies and a typo along the way.
* Temperature Unit | ||
* Display orientation | ||
* Cooldown blink | ||
* Scrolling Speed | ||
* Reverse Temp change buttons + - | ||
* Animation Speed | ||
* -Animation Loop | ||
* OLED Brightnes | ||
* OLED Brightness |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤦🏼
@Ralim Why I am not able to remove |
where is the |
Sorry, 🤦♂️ IronOS/Translations/translation_EN.json Line 69 in c89db78
IronOS/Translations/translation_EN.json Line 76 in c89db78
IronOS/Translations/translation_EN.json Line 83 in c89db78
IronOS/Translations/translation_EN.json Line 90 in c89db78
IronOS/Translations/translation_EN.json Line 97 in c89db78
& IronOS/Translations/translation_EN.json Line 316 in c89db78
As you know these are not displayed anyway. But if I try to just remove them, it results in an error when compiling. Also regarding IronOS/Translations/translation_EN.json Lines 311 to 317 in c89db78
should be moved from: IronOS/Translations/translation_EN.json Line 100 in c89db78
to: IronOS/Translations/translation_EN.json Line 63 in c89db78
since it is not a sub menu. |
As of present we force the desc stuff like that so that its the same format as others to simplify things. The language switch is a sub-menu item in that it does not have children menu's. |
Thank you for the clarification! |
Since in most appliances the reset option is placed somewhere near the end, this might be the way to go for IronOS as well.
The arrangement of
settingsGUI
has also been adapted to the current sorting of the menu.Fixed some inconsistencies and a typo along the way.