Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moved_reset_settings #1401

Merged
merged 3 commits into from
Sep 1, 2022
Merged

moved_reset_settings #1401

merged 3 commits into from
Sep 1, 2022

Conversation

discip
Copy link
Collaborator

@discip discip commented Aug 31, 2022

  1. Since in most appliances the reset option is placed somewhere near the end, this might be the way to go for IronOS as well.

  2. The arrangement of settingsGUI has also been adapted to the current sorting of the menu.

Fixed some inconsistencies and a typo along the way.

Since in most appliances the reset option is placed somewhere near the end, this might be the way to go for IronOS as well.

Fixed some inconsistencies and a typo along the way.
* Temperature Unit
* Display orientation
* Cooldown blink
* Scrolling Speed
* Reverse Temp change buttons + -
* Animation Speed
* -Animation Loop
* OLED Brightnes
* OLED Brightness
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦🏼

@Ralim Ralim merged commit 8cee506 into Ralim:dev Sep 1, 2022
@discip discip deleted the move_reset_entry branch September 1, 2022 11:22
@discip
Copy link
Collaborator Author

discip commented Sep 12, 2022

@Ralim
I do not want to open a separate issue, so I am asking here.

Why I am not able to remove desc for the menuGroups?
Any advice?

@Ralim
Copy link
Owner

Ralim commented Sep 13, 2022

where is the desc you are referring to?

@discip
Copy link
Collaborator Author

discip commented Sep 13, 2022

Sorry, 🤦‍♂️
I meant the desc in the language_xx.json files, like:

"desc": "Power settings"

"desc": "Soldering settings"

"desc": "Power saving settings"

"desc": "User interface settings"

"desc": "Advanced settings"

&
"desc": "Current firmware language"

As you know these are not displayed anyway. But if I try to just remove them, it results in an error when compiling.

Also regarding LanguageSwitch:

"LanguageSwitch": {
"text2": [
"Language:",
" EN English"
],
"desc": "Current firmware language"
},

should be moved from:
"menuOptions": {

to:

since it is not a sub menu.

@Ralim
Copy link
Owner

Ralim commented Sep 13, 2022

As of present we force the desc stuff like that so that its the same format as others to simplify things.
Also these are used for generating the Settings.md file.

The language switch is a sub-menu item in that it does not have children menu's.
Its just a submenu bought out to the main menu.
(If it helps, the distinction between Menu and submenu is purely just in the json file, from any codes point of view they are the same)

@discip
Copy link
Collaborator Author

discip commented Sep 13, 2022

Thank you for the clarification!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants