Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify and add details to documents #1383

Merged
merged 78 commits into from
Aug 24, 2022
Merged

Clarify and add details to documents #1383

merged 78 commits into from
Aug 24, 2022

Conversation

River-Mochi
Copy link
Contributor

@River-Mochi River-Mochi commented Aug 22, 2022

Add details to several documents and clarify other sections.
Added release information to the History document.

Thoughts:
- changing the name in display to "Calibrate Tip Offset" (currently shows Calibrate temperature) might be more clear, and then people will not get  nervous and think the number displayed means temperature? since it is just a number, i.e., 765,  and does not say  "765 offset"    I suggest changing to either  "number Offset"   or  changing menu name to "Calibrate Tip Offset"  .  when people incorrectly  beleive the high number is temperature, since it says "calibrate temperature?"  then it leads to unwarranted concern that the pinecil or IronOS is broken.
clarify language, add punctuation.
Documentation/Menu.md Outdated Show resolved Hide resolved
@River-Mochi River-Mochi requested a review from discip August 23, 2022 06:03
Copy link
Contributor Author

@River-Mochi River-Mochi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only question is for the Temperature.md file.
I'm not sure what this sentence means or if there is simply a Typo of the word "bad"

" it will regulate to within around +-3 °C but not indicate you are outside of this bad until you exceed +-5 °C"

is this meant to say something like...

"it will regulate to within around +/- 3 °C but not indicated you are outside of the margin of error until you exceed +/-5 °C. This gives the illusion that it's holding the temperature perfectly when in actuality it's moving around as well."

@Ralim
Copy link
Owner

Ralim commented Aug 23, 2022

Yeah thats a typo of "band".

But yes your replacement works :)

@River-Mochi
Copy link
Contributor Author

  • I changed Temperature.md to "out of margin of error"

  • changed Flashing page to show V2 has no update right now because we are getting at least 2-3 people daily in Chat saying they can't seem to update it and think there is a problem with their Iron. I think it would help to get that approved to display soon since chat represents only a small % of total new users, who may come to Github, but not even be members of chat. thanks

README.md Outdated Show resolved Hide resolved
River-Mochi and others added 4 commits August 23, 2022 15:59
Co-authored-by: discip <[email protected]>
In which troubleshooting conditions/symptoms would:

(1) Re-calibrating  tip offset temperature be appropriate?
(2) Re-Calibrating Input voltage be appropriate?

I think these 2 internal tests would be helpful sections for Troubleshooting, but not sure of all details to write-up.
@Ralim Ralim merged commit 3895218 into Ralim:dev Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants