Animation non block

[Ralim]

Buttons can now skip an animation in progress
Animations are faster

• Please check if the PR fulfills these requirements

• The changes have been tested locally
• There are no breaking changes

• What kind of change does this PR introduce?
  Should close Menu animation prevent moving quickly #1330

[River-Mochi]

This is related to Issue ticket #1330 also.

[discip]

@Ralim
I tried that with my trusty TS80P and have to say:
Only if you press and hold B the animations are skipped.
If you however only press B quickly in a consecutive manner there is not a whole lot speed change observable imho.

[discip]

@Ralim
What was this PR supposed to achieve?
Make the animation faster, leave the animation out completely on consecutive button-press?
How can I assist?

[Ralim]

Slightly faster animation
Dont allow animation playing to block you moving to the next item; so holding button or pressing rapidly should cancel animation and move on to next item as fast as possible.

[River-Mochi]

some people said that on pinecil, they did not like the new animations b/c it was not keeping up with button presses. They want the ability to press the buttons fast and not be delayed waiting for the entire animation to complete.
They were used to this in past firmware, but with the new animations, it affected their QOL and user experience.

[discip]

@Ralim

or pressing rapidly should cancel animation and move on to next item as fast as possible.

Yeah, that is what I expected when I first read the description of this PR.
But as I pointed out above animations are only skipped when B is held down, there is little to no change if B is pressed in rapid succession, though!
On the Pinecil it seems to work a bit faster compared to TS80P, since it has a faster mpu, but it does not keep up on either of them!

ps: Does it work for you the way you described it?

[River-Mochi]

I tried the beta and I like it , it's much faster now when I press the button fast, it seems to keep up on the display. I had no issue just pressing the button slower before this beta ( I don't want to break pinecil so I'm gentle on buttons) , but other people in discord did complain about it not being like older firmware. therefore Ralim made the beta. so you could skip animations the moment you press the button.