Infinite logo #1309
Infinite logo #1309
Conversation
|
Just to confirm: |
| // Delay here until button is pressed or its been the amount of seconds set by the user | ||
| waitForButtonPressOrTimeout(TICKS_SECOND * getSettingValue(SettingsOptions::LOGOTime)); | ||
| delay(); | ||
| return; | ||
| } | ||
| } while (buttons == BUTTON_NONE); |
There was a problem hiding this comment.
@Ralim
Good morning Sir,
nice to hear from you again! 😃😊
Hopefully you are doing well!
Now to the code.
Isn’t this line enough?
What does your approach do to make the code more reliable?
No accusation or sarcasm, just trying to understand. You know I’m not that good in this field.
There was a problem hiding this comment.
Hahah dont worry I've not gone anywhere; just been poking other projects for a bit of a break.
So I just added the case for if the timeout is 5; then we use the waitForButtonPress instead since we dont want a timeout.
( I should note its basically the same for the new logo path, I think its just the old logo path that had issues but i didnt dig)
There was a problem hiding this comment.
Alright! 👍
Ah, I see.
So, am I right about the do-while-loop being redundant?
Fixes the infinite delay setting for the bootup logo
#1285