-
-
Notifications
You must be signed in to change notification settings - Fork 731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pinecil pd tweaking #1272
Pinecil pd tweaking #1272
Conversation
Is this only applicable to the Pinecil? |
The code will not fit on the TS80P sadly |
Oh that's a pity. btw |
Its only a few bytes saved; so not enough. |
No worries, you don't need to feel bad about that! 😃 |
What changes for the TS80P regarding 9689c05? |
Not using freestanding mode so lto can drop a tiny bit more code. Frees up around 200 bytes, enough that we squeeze in |
Does that affect the accuracy or the performance some how? |
Should not, just trades off different types of optimisation :) |
What about the hall related stuff @alvinhochun brought up instead? |
It will save like 5 bytes; which is not a huge amount 🤣 |
You raised my concern by adding the crying smiley (😢) to the commit, what was it than about if there is nothing worrisome? |
here is some testing (video) I did with multiple chargers. only weird thing is that I am seeing 3.5amps on chargers that say on box max 3.25amps. non_daniel said I can not trust the 3.5amps. notice when I flip the Cable that is plugged into the right side of the USB-tester, I get State 6 https://www.youtube.com/watch?v=dxAC8iQOVy0&ab_channel=RiverB. The tester I am using. https://smile.amazon.com/gp/product/B07DCTG6LH Separately, I notice that some of my chargers that said they were 3.25Amp only show as 3.0amps. |
I also am getting [5 20v 3.5amps] just using a normal PD60W cable to Pinepower and I don't think I should be seeing 3.5amps on that cable? This is using the red USB-C cable I bought from Pine64 + PinePower desktop. |
Raise PD max voltage to 21V (for PPS)
Adding a PD read out menu
Cache VBus mod a bit
Add VBus mod info to PD menu as well
What is the current behavior?
If on Pinecil, and you boot while holding the front button (+), it will allow inspecting the PD data.
Pressing the rear button (-) will exit the menu and continue boot