Logo rework

[Ralim]

• Please check if the PR fulfills these requirements

• The changes have been tested locally
• There are no breaking changes

• What kind of change does this PR introduce?

Support for new logo support that (a) fixes the old endian issue and (b) allows animation.
Removes logo's from this repo and instead places them in the Meta repo.

• What is the current behavior?

• What is the new behavior (if this is a feature change)?

• Other information:

Closes #1173
Closes #1228
Closes #617
Closes #446
Inches closer to supporting #292

[Ralim]

@discip and @river-b
I'm sure you will want to start testing this with the IronOS-Meta logos

[discip]

@Ralim
I am on it finetuning IronOS.gif.
As soon as this fits, I'll replace the previous one. 😊

[Ralim]

❤️
I was really hoping this would take your attention and we would end up with an epic intro animation :)

[discip]

@Ralim
I really like to help and to contribute to your great work.

This is kind of a PM.
I don't know if you are Christian but please do not use the horned hand symbol, since it is a satanic one.

I hope you get me right.

thank you

[Ralim]

Ah okay apologies, over here its love_you_gesture :/
https://emojipedia.org/love-you-gesture/
Seems to be from American Sign Language :|

Definitely only intended as a "good" icon; and not to offend.
Wasn't aware of other meanings.

[Ralim]

Also i should add to answer the other part, absolutely love what you have done with animated logo so far, and I'm excited to see how you put this to use.

I spent a while trying to find a lean enough encoding to let some wise animation design work to get a fair few frames in, and I think this should be the most flexible one

[discip]

Ah okay apologies ...

Thank you for respecting that! ❤

I spent a while trying to find a lean enough encoding to let some wise animation design work to get a fair few frames in, and I think this should be the most flexible one

I think you did a great job on that one as well.
Hopefully I am able to live up to your expectation.

[Ralim]

Always happy to respect things like that. It's always a case of I just don't know, but always happy to be told about them. I'm assuming the heart is okay, though is there a preferred emoji version of " your awesome/thank you/etc"?

I don't meant to stress you by this but knowing that if I build it out your likely to come along and push it; it is excellent motivation to do a decent job the first time around. The classic motivation of knowing something will be used, and therefore the effort is justified.

[discip]

@Ralim

Also i should add to answer the other part, absolutely love what you have done with animated logo so far, and I'm excited to see how you put this to use.

Totally missed replying on that. 😓

I absolutely appreciate you acknowledging this!

And I am highly honored to be allowed to contribute to your project!

When I first stumbled over your 'custom firmware' I was astonished, that someone (you) dared and also managed to supercharge the already beautiful hardware!

Flashing the latest build of IronOS and the animation worked flawlessly!
Buuuut ... on the iron some frames get cut away.

Is the duration coupled to a certain amount of frames, or is it totally independent? (Maybe it should be dependent on the duration of the animation and only accept the input from the future duration menu if it is a static picture.)

[River-Mochi]

@Ralim I am on it finetuning IronOS.gif. As soon as this fits, I'll replace the previous one. 😊

what are the *.Gif used for? I thought we could only use png or bmp? @discip

[Ralim]

This changeset is for adding in support for animated boot logo's so gifs are an option now :)

[River-Mochi]

So I could tell the artist they can make gifs now? and how are Gifs converted into DFU?

[discip]

@river-b
Good morning,
all the files (.gif & .png) in here are automatically converted to .dfu & .hex files and put into a .zip file here on each CI run.

So you have to create a PR with new .gif & .png files and wait for CI to complete.

[River-Mochi]

@discip what is easiest for Artist to do? I'm trying to understand the procedure since we have to explain to new people how to make custom boot logos.
Scenarios
(1) Artist just wants to make art for themselves and not share: download python script, install python+pillow locally and using the provided script, convert any PNG or animated gif into DFU. Then upload the dfu it to Pinecil similar to firmware upgrade procedure.
(2) Artist wants to convert Png or animated Gif and willing to share art freely to others: they use IronOS-Meta repository, run Pull Request, everything is auto converted, people can download the correct Zip at bottom of Actions, for their correct equipment.

@Ralimtek
For Scenario #2, not that this would happen, but there could be NSFW images? it's a tiny screen but people are creative and there are very young people who buy pinecil & have access to github so that is one concern. Should there be some message in IronOS-Meta and documentation that NSFW images should not be loaded into the IronOS-Meta for PR, and to just use Python to do conversion locally on your PC ?
Also in some countries certain images/symbols are illegal. Anyway just putting that out there that for some things, people might be encouraged to locally do conversion and store their images without uploading to the Meta.

[discip]

@river-b

1. Create a fork of IronOS-Meta and proceed as mentioned above.
2. Create a new branch in your fork, put files which you want to share in and make a PR (Pull Request).

[Ralim]

@river-b
I definitely think most people are wise enough to know that NSFW content should not belong on the public web like in Meta.
People can fork and do what they want in their forks but should not PR back to the repo. I might add a note about this to Meta though.

My expectation that if its people doing it once off for themselves, it will work like before where they use the python script themselves.

If they want to give it back to the community then they can always think about a PR to meta

[Ralim]

This has been working well for me in my testing, and a bit better after the latest tweaks.
Would love your feedback on if this is working or not

[discip]

As mentioned above:

Flashing the latest build of IronOS and the animation worked flawlessly! Buuuut ... on the iron some frames get cut away.

Is the duration coupled to a certain amount of frames, or is it totally independent? (Maybe it should be dependent on the duration of the animation and only accept the input from the future duration menu if it is a static picture.)

and here #1241 (comment) it works for the most part. 😊

[Ralim]

Did you retest after the push of 8a3a45e ? It changed the inter-frame delay to round to 5ms increments which allows slower frames which should help. Also it brings if its constraining the framerate now.

[discip]

Yes I did, since I merged all the changes you created PRs for into my fork.
But the fact that the animation is quitted to early remains, as mentioned in #1241.

[discip]

I don't know if I was supposed to test the latest commit, but I did and this has unfortunately no effect on the animation being interrupted.

[Ralim]

Which animation are you seeing interruption on?
Did you update to latest ironos-meta as well?

[discip]

Thank you!
Sorry, 😅 I missed the fact that there was an update as well.

Now the entire animation is shown, but the last frame is to short, so maybe adding a bit of extra time at the end?

[Ralim]

@discip
Okay try now if you get time 😓 I dont have time to test tonight but will try tomorrow if i can

[discip]

Will do later as you know by now. 😀

I have been thinking about the extra time at the end that it might be not a solution for every case.

I will test if duplicating the last frame will still be in the allowable size range.
That might help with the last frame.

Have a good refreshing night. 😃

regards

[discip]

@Ralim
Good morning Sir,
unfortunately I have to report, that this did not change a thing. 😓

[discip]

Still nothing.

[Ralim]

Hmm, which animation is not showing the last frame for the correct time?

[discip]

@Ralim
It's this one:
IronOS.gif.zip

[Ralim]

@discip
Can you share the .gif you used? Or is this the one thats in the meta repo already?
Note I've also pushed a few touches to meta

[discip]

@Ralim

Or is this the one thats in the meta repo already?

Yep, that is exactly it. 😊

Note I've also pushed a few touches to meta

This time I considered that for testing! 😁

But, it still exits immediately after the animation is finished, without waiting for 4s. 🤷‍♂️

[Ralim]

Ohh

The logo isn't meant to wait for four seconds, that's only for static images

[discip]

🤦‍♂️
Sorry I thought this 5a8fc42 was meant to do this.

Is there a chance to get the 4s as absolute runtime for static images but for animations as addition at the end?

[Ralim]

My intention was that the logo exit's after the gif finishes.
Since your PR was adding in a time duration, I would rather merge this mess in and then finish out yours to add a time control?

[discip]

I am fine with that!
If you did test it for static images to work than merge it in, otherwise I will do it right now and report back.

[River-Mochi]

adding time at the end of the animation would be great because it ends way to fast, thanks for doing this.

[discip]

@Ralim
It is good to go! 👍