Add raw hall effect output to the debug menu.

[ritkit]

• Please check if the PR fulfills these requirements

• The changes have been tested locally
• There are no breaking changes

• What kind of change does this PR introduce?
  Adds a raw hall effect debug menu item for troubleshooting hall effect sensor.

Changes are made to make_transition.py and GUIThread.cpp/

• What is the current behavior?
  Hall effect output cannot be viewed.

• What is the new behavior (if this is a feature change)?
  Can now click through debug menu to see raw hall effect sensor output.

• Other information:
  Will build and test shortly.

[Ralim]

Hia,
Looks good to me. If CI passes then should be good to go. Can you give it a test on the CI builds once those are done?

[ritkit]

Hia, Looks good to me. If CI passes then should be good to go. Can you give it a test on the CI builds once those are done?

Yes, I can. Waiting on my hall effect sensor to arrive Monday. Will get it soldered up and a build for pinecil to test.

[ritkit]

I just realized, I probably should have used

#ifdef HALL_SENSOR

So this code can support the other builds without the hall effect sensors.

[Ralim]

Yeah good point, that's what the CI checks are there for

[Ralim]

clang-format is a picky pain but it does sorta help in making everything perfectly identical. Apologies for the pain

[ritkit]

Hahaha, ya. It also doesnt help I am starting with a fresh dev environment on my own computer with no clang format checks or anything. Trying Atom.io out.

[ritkit]

Alright, flashed my iron with this code. Changes don't break the iron. Hall reads out 0 which makes sense as it does not have the hall effect sensor in it.

Once I get the hall effect sensor soldered on, I can update this pull request with results if you want me to.

Also what a difference from 2.13 (what my iron shipped with) to now. Bravo.

[Ralim]

Hoping you like all the upgrades so far :)

Yeah if you can verify it would be great. If I get time to verify before then I'll merge it in

[discip]

@ritkit @Ralim
I don't know if this is covered by this PR, but it would be nice if the settings for the hall effect sensor would only show up, if it was actually populated onto the PCB.

thanks

[Ralim]

@discip The debug menu is meant to be super simple so it doesnt really do "skip if not present" at the moment as that can be more confusing?

The settings in the settings menu should only show if its present tho.

[discip]

@Ralim

The settings in the settings menu should only show if its present tho.

Yes that's what I thought at first, but I did not populate the required hall sensor onto the board and still I am able to set the sensitivity of it. 😵

The fact that the setting was available made me assume that the sensor was installed in the first place.

Edit:

I have just opened up the Pinecil and realized, that the hall sensor is actually already there, but it does not react, regardless of which sensitivity is set. Even more 😵😵.

[ritkit]

@discip

Edit:

I have just opened up the Pinecil and realized, that the hall sensor is actually already there, but it does not react, regardless of which sensitivity is set. Even more 😵😵.

Really!! Mine definitely does not have the hall effect sensor and the documentation on their wiki says it should be unpopulated.

I still need to get mine soldered on. What is your board version?

[discip]

@ritkit

Really!! Mine definitely does not have the hall effect sensor and the documentation on their wiki says it should be unpopulated.

Sorry! You are absolutely right!

My board is also missing the sensor! 😅

I made this conclusion based on a photo that was claimed to show the soldered part,

but I did not go the extra step to take a peek on the other side of the board. 🤦‍♂️😓

Your photos are depicting exactly the same situation I found in my Pinecil (including the version number).

[Firebie]

It is due

#define HALL_SENSOR

in the .\source\Core\BSP\Pine64\configuration.h

[discip]

@Firebie

It is due

#define HALL_SENSOR

in the .\source\Core\BSP\Pine64\configuration.h

Ah now I get this! 🤦‍♂️
So it is based on the iron not on the presence of the hall sensor!

Thank you for pointing this out! 😃👍

[discip]

@Ralim

The settings in the settings menu should only show if its present tho.

But than I don't get why the settings for it are available? 🤷‍♂️🤯 Or what did you mean by that?

[River-Mochi]

Hall sensor location on the U14 spot. I installed on 2 different pinecil this week.
This is BEFORE and AFTER install.

Model I purchased at Digikey -
notice there are 3 qty tiny ones.

This is 3 hard drive magnets stacked together on metal stand, which activates the hall sensor Zzzzzz.
Sensor is on HIGH setting but it still needs magnets very close to work. If I use just one magnet, I have to hold it right against pinecil for it to work.
I tried flipping it every direction. some directions don't work at all because of magnet direction.

[Ralim]

Just did a tweak to print absolute value but otherwise it works :) @ritkit