Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

idlescreenBG -> buttonA & buttonB #1188

Merged
merged 9 commits into from
Jan 20, 2022
Merged

idlescreenBG -> buttonA & buttonB #1188

merged 9 commits into from
Jan 20, 2022

Conversation

discip
Copy link
Collaborator

@discip discip commented Jan 19, 2022

Since the icon for the B-button is for all versions the same I split idlescreenBG in half.

Updated icons for MHP30:
buttonA
buttonA
missing plate
missing tip

Credits to @TRaMeLL #1119 (reply in thread).

Tested for TS80P.

@Ralim
Copy link
Owner

Ralim commented Jan 19, 2022

So thinking out loud, I havent checked, but if we split the screen do we still need the flipped form or can we just draw with different starting offsets from the left?
(Havent checked)

@discip
Copy link
Collaborator Author

discip commented Jan 19, 2022

@Ralim
Actually ˋbuttonBˋ should work without being flipped.
But since we can't foresee when the icons get updated into whatever design, I think the flipping 'action' should be kept.

The ˋbuttonBˋ needs to be flipped either way to please all the lefties out there. 😊

By the way:
I don't understand, why the previous idkescreenBG icon and now the buttonA & buttonB have to be read from right to left
and not the way the disconnectedTip icon (left to right) is handled?

Edit:
I noticed, by comparing the sizes of idkescreenBG (84) and disconnectedTip (41), that the later is not exactly half the size of the former. Ideally this should be 42. May I change this, or are there any implications I can't see right away?

@Ralim
Copy link
Owner

Ralim commented Jan 19, 2022

I'm happy to keep the flipping action, was just thinking out loud. Not expecting you to change.

I don't understand, why the previous idkescreenBG icon and now the buttonA & buttonB have to be read from right to left
and not the way the disconnectedTip icon (left to right) is handled?

Not 100% following this sorry

I noticed, by comparing the sizes of idkescreenBG (84) and disconnectedTip (41), that the later is not exactly half the size of the former. Ideally this should be 42. May I change this, or are there any implications I can't see right away?

It saves two bytes :D

@discip
Copy link
Collaborator Author

discip commented Jan 19, 2022

@Ralim

Not 100% following this sorry

No problem, found the issue, in the latest edit this is fixed. 😊

It saves two bytes :D

I made them both the same size 42 and that actually saved even more. 😁

Please let me know if you like the new icons (MHP30) better.

@Ralim Ralim merged commit 2762593 into Ralim:master Jan 20, 2022
@discip discip deleted the idlescreenBG-->-buttonA-&-buttonB branch January 20, 2022 11:28
@Ralim Ralim added this to the 2.17 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants