-
-
Notifications
You must be signed in to change notification settings - Fork 731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add capability of writing logos in binary format #1178
Conversation
Extended python script to support writing .bin files directly. This avoids the additional step of using objcopy. Updated the 001_PINECIL.bin file to match the PNG.
@cybernesto thanks in advance |
Changed name of Pinecil logos to match current naming.
Gotcha. I only noticed this was changed today. Hopefully the merge worked correctly. Let me know if any other changes are required. |
Great! Thank you! 😃👍 |
I don't know, since I neither tested this, nor do I need the |
Oh, the .bin files are working fine. I was just wondering if the commit in my branch got correctly reflected here but it looks like it went well. |
@Ralim first has to approve this PR and if I got this right, it simplifies things, so its merger should be welcomed. |
This looks good to me ❤️ First time you contribute code all the CI and such waits for me to hit OK, just incase you inject a CI step that takes over the codebase :) Do you think you could go the next step and pull in the functions from the dfu-util packer so we just create a .dfu file that is directly flashable? |
Yeah, I can give it a try. Would it make sense to do it in a separate pull request though? |
Yes it would, was just asking here (and waiting for CI) Thank you though for this :) |
@cybernesto |
What kind of change does this PR introduce?
Feature: Extended python script to support writing .bin files directly. This avoids the additional step of using objcopy.
What is the current behavior?
img2ts100.py can only create .hex files. objcopy is necessary to convert it into a .bin file.
What is the new behavior (if this is a feature change)?
img2ts100.py can create .bin files directly.
Other information:
The 001_PINECIL.bin file now matches the updated PNG logo.