Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add capability of writing logos in binary format #1178

Merged
merged 4 commits into from
Jan 13, 2022

Conversation

cybernesto
Copy link
Contributor

  • Please check if the PR fulfills these requirements
  • The changes have been tested locally
  • There are no breaking changes
  • What kind of change does this PR introduce?
    Feature: Extended python script to support writing .bin files directly. This avoids the additional step of using objcopy.

  • What is the current behavior?
    img2ts100.py can only create .hex files. objcopy is necessary to convert it into a .bin file.

  • What is the new behavior (if this is a feature change)?
    img2ts100.py can create .bin files directly.

  • Other information:
    The 001_PINECIL.bin file now matches the updated PNG logo.

cybernesto and others added 2 commits January 12, 2022 17:45
Extended python script to support writing .bin files directly. This avoids the additional step of using objcopy.

Updated the 001_PINECIL.bin file to match the PNG.
@discip
Copy link
Collaborator

discip commented Jan 12, 2022

@cybernesto
Thank you! 👍
I would hate to create a separate PR on the following, so please change the name of 001_PINECIL.bin to Pinecil.bin and add Pinecil_L.bin in as well?

thanks in advance
kind regards

@cybernesto
Copy link
Contributor Author

Gotcha. I only noticed this was changed today. Hopefully the merge worked correctly. Let me know if any other changes are required.

@discip
Copy link
Collaborator

discip commented Jan 12, 2022

Great! Thank you! 😃👍

@discip
Copy link
Collaborator

discip commented Jan 12, 2022

Hopefully the merge worked correctly.

I don't know, since I neither tested this, nor do I need the *.bin files.
I just wanted to prevent people complaining about the *.bin files not working. 😁

@cybernesto
Copy link
Contributor Author

Oh, the .bin files are working fine. I was just wondering if the commit in my branch got correctly reflected here but it looks like it went well.

@discip
Copy link
Collaborator

discip commented Jan 12, 2022

@Ralim first has to approve this PR and if I got this right, it simplifies things, so its merger should be welcomed.

@Ralim
Copy link
Owner

Ralim commented Jan 12, 2022

This looks good to me ❤️

First time you contribute code all the CI and such waits for me to hit OK, just incase you inject a CI step that takes over the codebase :)

Do you think you could go the next step and pull in the functions from the dfu-util packer so we just create a .dfu file that is directly flashable?
https://github.com/Ralim/IronOS/blob/master/source/dfuse-pack.py

@cybernesto
Copy link
Contributor Author

Yeah, I can give it a try. Would it make sense to do it in a separate pull request though?

@Ralim
Copy link
Owner

Ralim commented Jan 13, 2022

Yes it would, was just asking here (and waiting for CI)

Thank you though for this :)

@Ralim Ralim merged commit 77fe3f3 into Ralim:master Jan 13, 2022
@discip
Copy link
Collaborator

discip commented Jan 13, 2022

@cybernesto
There is a request from earlier this year addressing this topic: #798? 😊

@Ralim Ralim added this to the 2.17 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants