-
-
Notifications
You must be signed in to change notification settings - Fork 746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable Bluetooth by default to minimize attack vectors #1856
Comments
We can default the blue interface off; however it then caused confusion for people when apps didn't work 😢. |
Wouldn't that simply mean telling people to enable it? |
Yeah it would, but if there is something we have learned, is that the average user doesn't read half the time and instead prefers to just rant on review sites >_<. But I do agree, even though the risk is super minimal; it is safer to default off. |
I got this ;) |
I'm not android app developer myself but probably from the point of better user experience it would be nice if in
|
Hello I'm a blind user and really enjoy the integrations offered by the BLE functionality in the Pinecil. Community tools like Pinesam and Pine Tool allow me to set and monitor my tip temperatures, as well as change device settings that I otherwise could not perceive. Is there a documented set of button presses to re-enable BLE after this update? e.g., starting from power on, how do I get to and enable BLE? And can this be setting persist across reboots? I understand the need to disable the feature by default as a security measure. For those that rely on it, though, we should document how to re-enable it as it offers some fantastic accessibility options. |
Hello, @doubletaco . First of all, thank you for this feedback and, please, sorry for any inconvenience which may happened by disabling Bluetooth by default.
This is very good hint about documenting it, since even @Ralim did notice that a lot of people may be confused by not being able to make a Bluetooth pairing.
Yes, of course! So, please, don't worry! Every time you change any setting in the menu, it will be saved on every exit from the menu. On top of that, your custom settings should be persisted even between flash updates (unless there wasn't a really big rework on setting routines in the code). So the fact that now Bluetooth is disabled by default, doesn't mean that when at the next time you flash/update your Pinecil with the next stable build, your setting of Bluetooth will be off. If you have Bluetooth enabled now, this setting should survive not only reboots/turn offs, but the flash update to the next stable version.
Could you, please, participate in the review, then? I'm not sure how to address getting into Settings menu in the step 1, since it depends in which state the iron is (soldering mode vs sleeping/hibernating/cooling off mode). But what do you think if the instruction will be sounded something like this: To enable Bluetooth back:
|
Description
Bluetooth is enabled by default, which presents a potential attack vector due to the lack of authentication. Potential attacks range from pranks like setting a low temperature to an attacker potentially causing an unattended iron to start a fire.
Steps to Reproduce
Expected Behavior
Bluetooth would either be disabled by default, or an authentication step would occur during pairing.
Device Details
The text was updated successfully, but these errors were encountered: