Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animated Boot Logo. Continuously repeat animation when boot logo duration is set to infinity. #1839

Closed
jhapke opened this issue Nov 16, 2023 · 8 comments
Assignees
Labels
Enhancement New feature or additional function.

Comments

@jhapke
Copy link

jhapke commented Nov 16, 2023

It would be cool if the boot logo animation continued to repeat until a button is pressed, only if the boot logo duration is set to infinity.

@jhapke jhapke added the Enhancement New feature or additional function. label Nov 16, 2023
@ia
Copy link
Collaborator

ia commented Nov 17, 2023

TL; DR: I take it! At least I will try to experiment on this so @Ralim could have more free time for more important tasks.

Hello, @Ralim. I looked through related parts of the code very briefly so far. And I don't want to take any obligations not to let anyone down. But as far as I understand this feature looks implementable unless I'm not aware of some very tricky nuances as always. So I'm going to find some free time to experiment with this feature during this weekend so you could have more time for more important low-level improvements & features like that very nasty MHP30/GD problem. 🤞

@ia
Copy link
Collaborator

ia commented Nov 19, 2023

Status update: it seems it works but I need a bit more time to do additional checks & prepare pull request. Will try be back during the day.

@discip
Copy link
Collaborator

discip commented Nov 20, 2023

@ia
Are you planning on making this optional?
Since I don't want the boot logo to loop.

kind regards

@ia
Copy link
Collaborator

ia commented Nov 20, 2023

Since I don't want the boot logo to loop.

Don't worry.

Are you planning on making this optional?

Yes, exactly. That was one of the reasons why it took longer than I thought.

@Ralim
Copy link
Owner

Ralim commented Nov 20, 2023

An option here is we could add a flag to the logo file rather than an on-device setting. Or we could make the timeout option have two infinities; an infinite time and an infinite++ time that loops.

(just as a thought).

@discip
Copy link
Collaborator

discip commented Nov 20, 2023

To save precious space I tend to vote for the first option.

But what would be the cost for that?
Would we get multiple logo files (looping once / endless)?

@ia
Copy link
Collaborator

ia commented Nov 20, 2023

Builds with this feature are ready in case if anyone would like to try.

A few notes:

  • if the boot logo is animated & the setting is to infinite, then animation is being shown on repeat until a button press;
  • to set "old" behavior (roll logo once & halt), use 1 option value (as in one time) for the animation setting in the menu;
  • no changes for a static logo: both "1" and "infinity" options do the same for a static logo as before.

discip added a commit that referenced this issue Nov 23, 2023
Implement optional looping for animated boot logo [#1839]
@discip
Copy link
Collaborator

discip commented Nov 23, 2023

Done! 😊
Kudos to @ia.

@discip discip closed this as completed Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or additional function.
Projects
None yet
Development

No branches or pull requests

4 participants