-
-
Notifications
You must be signed in to change notification settings - Fork 731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Animated Boot Logo. Continuously repeat animation when boot logo duration is set to infinity. #1839
Comments
TL; DR: I take it! At least I will try to experiment on this so @Ralim could have more free time for more important tasks. Hello, @Ralim. I looked through related parts of the code very briefly so far. And I don't want to take any obligations not to let anyone down. But as far as I understand this feature looks implementable unless I'm not aware of some very tricky nuances as always. So I'm going to find some free time to experiment with this feature during this weekend so you could have more time for more important low-level improvements & features like that very nasty MHP30/GD problem. 🤞 |
Status update: it seems it works but I need a bit more time to do additional checks & prepare pull request. Will try be back during the day. |
@ia kind regards |
Don't worry.
Yes, exactly. That was one of the reasons why it took longer than I thought. |
An option here is we could add a flag to the logo file rather than an on-device setting. Or we could make the timeout option have two infinities; an infinite time and an infinite++ time that loops. (just as a thought). |
To save precious space I tend to vote for the first option. But what would be the cost for that? |
Builds with this feature are ready in case if anyone would like to try. A few notes:
|
Implement optional looping for animated boot logo [#1839]
Done! 😊 |
It would be cool if the boot logo animation continued to repeat until a button is pressed, only if the boot logo duration is set to infinity.
The text was updated successfully, but these errors were encountered: