Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Y/N instead of T/F #168

Closed
ulab opened this issue Dec 17, 2017 · 13 comments · Fixed by #183
Closed

Use Y/N instead of T/F #168

ulab opened this issue Dec 17, 2017 · 13 comments · Fixed by #183

Comments

@ulab
Copy link

ulab commented Dec 17, 2017

It took me a moment to realize what the T/F settings meant... Perhaps it's better to use Y/N (Yes/No) instead?

@Mrkvozrout
Copy link
Contributor

@ulab Hi, do you mean english or other language? This is currently up to each language translation (translator's choise).

@ulab
Copy link
Author

ulab commented Dec 18, 2017

English. I have installed the firmware without any language extension. (I'm still guessing T stands for True and F for False? :-))

This is something coders might realize, but for the "common people", I think Yes and No might be easier.

It's just a suggestion since it was the first thing that came to my mind yesterday.

@Mrkvozrout
Copy link
Contributor

Mrkvozrout commented Dec 18, 2017

Thanks to bring in your opinion and (re)start the discussion.

It is hard to decide what indication to choose (true/false, yes/no, +/-, active/passive, enabled/disabled...). I think the commonly most realizable would be to implement ✓✗ characters. I will try to play with it and share results (if someone wouldn't be faster :) ).

@matmemo
Copy link
Contributor

matmemo commented Dec 22, 2017

I had a similar feeling as @ulab when I did the german translation. In english it's kind of ok for me because it feels quite natural in a technical context if you've done some programming. But translated to german it really get's awkward. The English letters feel out of place and the german equivalent W/F isn't used in devices I know of and I doubt anybody would understand these letters at first glance anyway.

What I'm getting at is my favourite solution up to now. With the new double line mode for the settings it's posible to simply pose the concerned setting as a question, ending with a question mark. After that it's looks quite clear to me that I have to answer Yes or No (J/N in german).

Well that's just my two cents on the matter and I'd really like to know what others are thinking about that idea.

@Mrkvozrout
Copy link
Contributor

@matmemo I think that is really good solution. In my czech translation I bet on when users don't not know what the values are, they wait (or stare in confusion :D) until the description shows and they can read what thhe options mean.

What do you think about the ✓✗ chars?

@Rockman18
Copy link
Contributor

I've pushed a pull request #177 proposing a checkbox instead of T/F or Y/N

@SilverSho0t
Copy link

I think ✓✗ characters are a very good solution. It will simplify the menu.

@MichMich
Copy link

My first though would be ✓✗as well.

@wortex1979
Copy link

i think ✓✗ characters is very good

@Rockman18
Copy link
Contributor

Pull Request #177 add a checkbox intead of True/False. This PR has been merged in master last week but not compiled/released yet. The checkboxes look like that : checkbox_off checkbox_on

I've compiled a V2.02-alpha.1 in English to share it with you. Tell me your opinion for thoses checkboxes.

TS100_v2.02-alpha.1_EN.zip

@SilverSho0t
Copy link

Very nice @Rockman18 much more understandable & user friendly ;)

@MichMich
Copy link

Look much better than the T/F. Awesome. You might want to add a bit of margin at the bottom so that it is better aligned to the inter of the screen.

@Mrkvozrout
Copy link
Contributor

Mrkvozrout commented Jan 2, 2018

@Rockman18 good work, you were faster :)

I offer my pull request #183 with updated checkboxes with discussed ✓✗ chars. I think it looks neater and even more understandable (as the X looks more descriptive then current empty checkbox).

What do you guys think? (see PR for photos)

@Ralim Ralim closed this as completed in #183 Mar 3, 2018
tabudz added a commit to tabudz/IronOS that referenced this issue Feb 26, 2025
Ralim pushed a commit to tabudz/IronOS that referenced this issue Feb 28, 2025
Ralim pushed a commit to tabudz/IronOS that referenced this issue Mar 1, 2025
Ralim pushed a commit that referenced this issue Mar 1, 2025
* Fix for #168

* Adapt style ecc_dsa.c

* Update ecc_dsa.c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants