Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

corrupted animation if result is exactly 1024 bytes #18

Closed
discip opened this issue Jul 30, 2022 · 5 comments · Fixed by Ralim/IronOS#1362
Closed

corrupted animation if result is exactly 1024 bytes #18

discip opened this issue Jul 30, 2022 · 5 comments · Fixed by Ralim/IronOS#1362

Comments

@discip
Copy link
Collaborator

discip commented Jul 30, 2022 •
edited
Loading

Unfortunately I have encountered another limitation of the 'compile script'.

If a file fills up the space of 1024 byte exactly, the compiled dfu is corrupted, because there are 2 more frames at the end of the animation, which consist of 1 entirely white screen and 1 where only the upper half is white.

Please help.

reference: https://github.com/discip/IronOS-Meta/actions/runs/2766439271
@discip
Copy link
Collaborator Author

discip commented Jul 31, 2022 •
edited
Loading

@Ralim
Good morning Sir,
does a 👍 mean that you are already on it?
And if so, how can I assist?

btw:
Is it possible to log not only the amount of frames, but also the name of the corresponding .gif?

Thanks in advance

@Ralim
Copy link
Owner

Ralim commented Aug 6, 2022

Hia,
The 👍🏼 was meant to be "I've seen this and I'm aware; and ill be back when I have time to poke".Roughly anyway.

I think this is an IronOS bug. Happy to leave ticket here. Will try and get this patched for you shortly.

Is it possible to log not only the amount of frames, but also the name of the corresponding .gif?
Added this to main for you

@discip
Copy link
Collaborator Author

discip commented Aug 6, 2022

Thanks!
I'll try to be patient. 😊

@discip
Copy link
Collaborator Author

discip commented Aug 9, 2022

@Ralim
I recently found that there was already a similar problem in the past that you were able to solve (#7), but what could be causing it to appear again?

@discip discip mentioned this issue Aug 9, 2022
Merged
@discip
Copy link
Collaborator Author

discip commented Aug 9, 2022 •
edited
Loading

Ooops ... I just realized: I was the one creating this issue when working on the boot logo options! 😅

It is solved now! 😊

@discip discip closed this as completed Aug 9, 2022
Ralim pushed a commit to Ralim/IronOS that referenced this issue Aug 10, 2022
@discip
solves artifacts issue if .gif is exactly 1024 B (#1362)
e434490 
* solves artifacts issue if .gif is exactly 1024 B

solves Ralim/IronOS-Meta#18

* increased animation speed a tad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

solves artifacts issue if .gif is exactly 1024 B
2 participants
@Ralim @discip