Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to non-raw GitHub page, with edit link #1533

Merged
merged 1 commit into from
Sep 4, 2017

Conversation

zakame
Copy link
Member

@zakame zakame commented Sep 4, 2017

Let the pod6 docs link to their non-raw GitHub pages, so visitors can
see and maybe help out on improving some more. And for convenience,
also provide an edit link.

There's probably some more improvement to do on the footer as well; will
further work on separate commits/PRs.

Let the pod6 docs link to their non-raw GitHub pages, so visitors can
see and maybe help out on improving some more.  And for convenience,
also provide an edit link.

There's probably some more improvement to do on the footer as well; will
further work on separate commits/PRs.
@rafaelschipiura
Copy link
Contributor

There's still the issue that Github can't render Pod6: github/markup#907

@zakame
Copy link
Member Author

zakame commented Sep 4, 2017

@rafaelschipiura ouch, that's a bit annoying, but not too bad that we can't view the raw pod6. I probably should have made it clear in the original PR text that I mean changing the link to a page with the GitHub amenities, rather than to a direct raw text of the pod6.

OTOH, how can I help getting Pod6 rendering to happen?

@AlexDaniel
Copy link
Member

This ticket is related to #1212.

For github pod parsing see #167.

@rafaelschipiura
Copy link
Contributor

@zakame I do think it would be better to link to the decorated Github page instead of the raw text, so I agree with merging this. But it doesn't fix #1212, since that is requesting a link to the composed page.

@zakame
Copy link
Member Author

zakame commented Sep 4, 2017

But it doesn't fix #1212, since that is requesting a link to the composed page.

@rafaelschipiura that's probably splitting hairs since #1212 doesn't explicitly say about linking to a fully composed/rendered page, only that we can get to a page where we can proceed to edit (see further context in #53 (comment).) Either way though, I think the core problem (to fix a link to point somewhere we can proceed to do further action later) is hopefully solved by this PR.

@AlexDaniel AlexDaniel merged commit f7c9224 into Raku:master Sep 4, 2017
@zakame
Copy link
Member Author

zakame commented Sep 5, 2017

Thanks @AlexDaniel ! 🎉

@zakame zakame deleted the link-to-non-raw-pages-on-github branch September 5, 2017 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants