Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty pulls crash the SimulationCraft integration #2574

Closed
Wotuu opened this issue Oct 17, 2024 · 1 comment
Closed

Empty pulls crash the SimulationCraft integration #2574

Wotuu opened this issue Oct 17, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@Wotuu
Copy link
Contributor

Wotuu commented Oct 17, 2024

[2024-10-17 12:00:16] production.ERROR
Attempt to read property "id" on null
Context
{
"correlationId": "70543545-f7a4-468f-87e7-1e4591701842",
"publicKey": "TxMpIiy",
"mappingVersionId": 404,
"userId": 1
}
On /var/www/html/keystone.guru.live/releases/52/app/Logic/SimulationCraft/RaidEventPull.php:68 (code 0)

@Wotuu Wotuu added the bug Something isn't working label Oct 17, 2024
@Wotuu Wotuu changed the title Enmy pulls crash the SimulationCraft integration Empty pulls crash the SimulationCraft integration Oct 17, 2024
@Wotuu Wotuu self-assigned this Oct 20, 2024
@Wotuu
Copy link
Contributor Author

Wotuu commented Oct 20, 2024

I couldn't reproduce it for the life of me. And I had already fixed those offending routes on prod. Sooo since I couldn't reproduce it I just made a quick fix to make this not happen again. The root cause is still unknown. Maybe something to do with facades.. but it looks like ->getDominantFloor() returns null somehow (which kinda makes sense for empty pulls, but those pulls should not reach this code anyway since there's already checks for empty pulls.. 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant