Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request - Support Text Formatting for Pull Descriptions #2176

Closed
mikeyv19 opened this issue Jan 9, 2024 · 7 comments
Closed

Feature Request - Support Text Formatting for Pull Descriptions #2176

mikeyv19 opened this issue Jan 9, 2024 · 7 comments
Assignees
@Wotuu
Labels
enhancement New feature or request map Issue that is related to the map

Comments

@mikeyv19
Copy link

mikeyv19 commented Jan 9, 2024

Would love the ability to format text within "Pull Descriptions". Don't need a fancy formatting bar, but if something like HTML tags were supported within the text box, that would be a nice feature.

Having the ability to do line breaks or bold certain things personally helps make the route more readable for me.
@Wotuu
Copy link
Contributor

Wotuu commented Jan 11, 2024

I like the idea, but I'll have to play around with what feels good. Thanks for the suggestion 👍

@Wotuu Wotuu added enhancement New feature or request map Issue that is related to the map labels Jan 12, 2024
@Wotuu Wotuu self-assigned this May 9, 2024
@Wotuu
Copy link
Contributor

Wotuu commented May 9, 2024

Heya, sorry this took so long! I just got around to doing this. How does this look? It supports these tags atm, if you want to see more added let me know!

@Wotuu
Copy link
Contributor

Wotuu commented May 9, 2024

image

Wotuu added a commit that referenced this issue May 9, 2024
@Wotuu
#2176 Added support for some HTML tags in various user inputs (map ic…
b051998 
…ons, pull descriptions)
Wotuu added a commit that referenced this issue May 10, 2024
@Wotuu
#2176 Made it more visual what tags are supported in each section.
9c286fa
@Wotuu
Copy link
Contributor

Wotuu commented May 10, 2024

I will just close this since I don't know if you're ever going to read this! But if you do, feel free to re-open this ticket. Thank you once again!

@Wotuu Wotuu closed this as completed May 10, 2024
Wotuu added a commit that referenced this issue May 10, 2024
@Wotuu
#2176 Moved the description text up in the pull descriptions edit modal.
87469de
@mikeyv19
Copy link
Author

Thank you! Looks great, appreciate the follow up - still using Keystone guru every season XD - is this rolled into live yet or future release?

@Wotuu
Copy link
Contributor

Wotuu commented May 10, 2024 •
edited
Loading

Good to hear! Feedback like yours make the site better for everyone - so keep it coming please 😄. This is not live yet, but I will push it live soon. Maybe tomorrow, otherwise Sunday!

I also don't know why I started at h3, h4, h5 and h6 will be valid. I wanted the 3 smallest headers to be available.

Wotuu added a commit that referenced this issue May 10, 2024
@Wotuu
#2176 Updated the available html tags to be h4 h5 and h6 (removed h3).
6aa6948
This was referenced May 13, 2024
Closed
Merged
@Wotuu
Copy link
Contributor

Wotuu commented May 15, 2024

@mikeyv19 This is now deployed to production, enjoy and let me know how you like it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Wotuu Wotuu

Labels
enhancement New feature or request map Issue that is related to the map
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Wotuu @mikeyv19