arduino-uno: simple-servo example #628
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, first, thanks for this repo! I'm a rust beginner and to be honest I want to use it for some embedded programming hobby, no professional use right now. So I will be really happy to get some honest feedback about this code.
I know there is a lot of unsafe blocks, so it will be great if you can point some ways to deal with that, improve the code or anything honestly. Basically I just read the official arduino servo library where uses interruptions to update the servos when needed. I translate most of the code and after a lot of frustration, I ended with this code that allows the user to create a servo, attach it and set some angles in a very simple way.
Let me know if more info or changes are needed.