Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenAIConfigurationSettings inspector input fields aren't properly validated #29

Closed
StephenHodgson opened this issue Feb 6, 2023 · 0 comments · Fixed by #30
Closed

OpenAIConfigurationSettings inspector input fields aren't properly validated #29

StephenHodgson opened this issue Feb 6, 2023 · 0 comments · Fixed by #30
Assignees
@StephenHodgson
Labels
bug Something isn't working

Comments

@StephenHodgson
Copy link
Member

We validate the inputs for the AuthInfo but not the OpenAIConfigurationSettings.asset

We should validate both apiKey and organization strings.

com.openai.unity/OpenAI/Packages/com.openai.unity/Runtime/AuthInfo.cs

Line 23 in 4cabf80

if (!organization.Contains("org-"))

com.openai.unity/OpenAI/Packages/com.openai.unity/Editor/OpenAIConfigurationSettingsInspector.cs

Line 52 in 4cabf80

EditorGUILayout.PropertyField(organization);

@StephenHodgson StephenHodgson added the bug Something isn't working label Feb 6, 2023
@StephenHodgson StephenHodgson self-assigned this Feb 6, 2023
@StephenHodgson StephenHodgson linked a pull request Feb 7, 2023 that will close this issue
com.openai.unity 2.2.2 #30
Merged
@StephenHodgson StephenHodgson mentioned this issue Feb 7, 2023
Merged
github-actions bot pushed a commit that referenced this issue Feb 7, 2023
@StephenHodgson
com.openai.unity 2.2.2 (#30)
f5bc655 
- Fixes #29 
- Added `OpenAIConfigurationSettings` input field validation
- Renamed `OpenAIConfigurationSettings.Organization` ->
`OpenAIConfigurationSettings.OrganizationId`
- Added changelog and documentation links in `package.json`
- Updated Readme and docs
- Bumped version to 2.2.2
- Updated some tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@StephenHodgson StephenHodgson

Labels
bug Something isn't working
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

com.openai.unity 2.2.2 RageAgainstThePixel/com.openai.unity
1 participant
@StephenHodgson