OpenAI-DotNet 8.2.4 #365
Merged
OpenAI-DotNet 8.2.4 #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
StephenHodgson
commented
Sep 14, 2024
•
StephenHodgson
commented
- Fixed ResponseObjectFormat deserialization when set to auto
- Added RankingOptions to FileSearchOptions
- Fixed potential memory leaks when uploading files to various endpoints
- Added timestamp values to BaseResponse to calculate rate limits
- Fixed ResponseObjectFormat deserialization when set to auto - Added RankingOptions to FileSearchOptions - Fixed potential memory leaks when uploading files to various endpoints
# Abstract The current headers return strings such as `12m30s`. If you want to consume this data, it needs to be parsed into a more usable format. This PR will add properties to the abstract class BaseResponse that will parse the header strings into something more useful. # Changes - Two new public readonly properties of type TimeSpan have been added to BaseResponse, `ResetTokensTimespan ` and `ResetTokensTimespan ` - The original properties have not been changed in order to avoid any breaking changes for downstream projects that may be relying on them. # Testing Methods Since regex done poorly can be a massive hindrance in terms of performance, the regex's performance has been tested using a separate project. The regex was run through 100k randomly generated timestamps. The code can be found [here](https://github.com/RealStillkill/OpenAI-DotNet-RegexMetrics). The compute time of the regex was negligible. This change was based on an extension method used in a private project. It has not produced any problems during its usage in the other project. --------- Co-authored-by: Stephen Hodgson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.