Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

thread messages and runs #171

Merged
merged 10 commits into from
Nov 16, 2023
Merged

thread messages and runs #171

merged 10 commits into from
Nov 16, 2023

Conversation

khoroshevj
Copy link
Contributor

StephenHodgson
StephenHodgson requested changes Nov 15, 2023
View reviewed changes
Copy link
Member

@StephenHodgson StephenHodgson left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Combine the namespaces and remove duplicate classes.
  • Ensure all types are immutable and don't contain pubic setters.

@StephenHodgson StephenHodgson marked this pull request as draft November 15, 2023 22:43
@khoroshevj
Copy link
Contributor Author

good comments, will do soon

@khoroshevj khoroshevj marked this pull request as ready for review November 16, 2023 07:00
StephenHodgson
StephenHodgson reviewed Nov 16, 2023
View reviewed changes
OpenAI-DotNet/Assistants/AssistantTool.cs
@@ -1,12 +1,27 @@
using System.Text.Json.Serialization;
using OpenAI.Chat;
using OpenAI.Extensions;

namespace OpenAI.Assistants
{
public sealed class AssistantTool
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use the existing Tool type?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/openai/openai-openapi/blob/master/openapi.yaml#L7785 not sure why but they have separate type for this one, so I'd better stick to separate type too

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only thing that matters is if the fields are different I guess.

No matter, I'll validate later

StephenHodgson
StephenHodgson requested changes Nov 16, 2023
View reviewed changes
Copy link
Member

@StephenHodgson StephenHodgson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to remove the duplicate types and remove repetitive duplicate code structures.

@khoroshevj
Copy link
Contributor Author

remove repetitive duplicate code structures.

can you elaborate?

@StephenHodgson
Copy link
Member

@khoroshevj all good here?

@StephenHodgson
Copy link
Member

Just FYI I might do some more refactoring before release

@khoroshevj
Copy link
Contributor Author

ok

@StephenHodgson StephenHodgson merged commit 2f834f9 into RageAgainstThePixel:development Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephenHodgson StephenHodgson StephenHodgson requested changes

Assignees

@khoroshevj khoroshevj

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Threads Endpoint
2 participants
@khoroshevj @StephenHodgson