Thread messages and runs #169
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Lots of conflicts. I assumed you were done, so I started cleaning up what you gave me. |
thats not a big problem I guess, ping me when you finish I'll merge/rebase. I haven't finished some tests yet anyway |
|
@StephenHodgson I'm done here and will be ready to rebase when you merge #168 into the main |
|
Go ahead and rebase and get this in, and I'll finish my work later |
|
created new PR, closing this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm finishing run tests here and will be glad to hear feedback before processing further.
Also can split into two PRs "messages" and "runs"