Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assistants Endpoint #166

Merged
merged 4 commits into from
Nov 15, 2023
Merged

Assistants Endpoint #166

merged 4 commits into from
Nov 15, 2023

Conversation

khoroshevj
Copy link
Contributor

@khoroshevj khoroshevj commented Nov 15, 2023 •
edited by StephenHodgson
Loading

StephenHodgson
StephenHodgson requested changes Nov 15, 2023
View reviewed changes
Copy link
Member

@StephenHodgson StephenHodgson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It's a good start but seems like it needs a lot of work still.

Please be sure to go back and change all the response objects to immutable types and sealed class modifier.

@khoroshevj
Copy link
Contributor Author

ok, added sealed modifiers and changed response collections to readonly

@StephenHodgson
Copy link
Member

Great, I'll probably take both these changes into development and do some final passes and testing before releasing.

Thanks for submitting!

@StephenHodgson StephenHodgson changed the base branch from main to development November 15, 2023 16:26
@StephenHodgson StephenHodgson merged commit 4b92dd8 into RageAgainstThePixel:development Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephenHodgson StephenHodgson StephenHodgson requested changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Assistants Endpoint
2 participants
@khoroshevj @StephenHodgson