Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenAI-DotNet 7.2.3 #162

Merged
merged 11 commits into from
Nov 12, 2023
Merged

OpenAI-DotNet 7.2.3 #162

merged 11 commits into from
Nov 12, 2023

Conversation

chsword
Copy link
Contributor

@chsword chsword commented Nov 12, 2023 •
edited by StephenHodgson
Loading

  • Added support for reading RateLimit information from the Headers

StephenHodgson
StephenHodgson requested changes Nov 12, 2023
View reviewed changes
Copy link
Member

@StephenHodgson StephenHodgson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Please fix formatting and update version and release notes

@StephenHodgson StephenHodgson changed the title feat: +rate limits https://platform.openai.com/docs/guides/rate-limit… OpenAI-DotNet 7.2.3 Nov 12, 2023
@chsword
Copy link
Contributor Author

chsword commented Nov 12, 2023

Thanks for the PR!

Please fix formatting and update version and release notes

I have formatted the code and added the version number and ReleaseNotes.

StephenHodgson
StephenHodgson requested changes Nov 12, 2023
View reviewed changes
Copy link
Member

@StephenHodgson StephenHodgson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

OpenAI-DotNet/Extensions/ResponseExtensions.cs Outdated Show resolved Hide resolved
OpenAI-DotNet/Completions/CompletionResult.cs Outdated Show resolved Hide resolved
OpenAI-DotNet/Completions/CompletionResult.cs Outdated Show resolved Hide resolved
OpenAI-DotNet/Chat/ChatResponse.cs Outdated Show resolved Hide resolved
OpenAI-DotNet/RateLimits.cs Outdated Show resolved Hide resolved
OpenAI-DotNet/IUseRateLimits.cs Outdated Show resolved Hide resolved
OpenAI-DotNet/Extensions/ResponseExtensions.cs Outdated Show resolved Hide resolved
OpenAI-DotNet/Chat/ChatEndpoint.cs Outdated Show resolved Hide resolved
StephenHodgson
StephenHodgson reviewed Nov 12, 2023
View reviewed changes
Copy link
Member

@StephenHodgson StephenHodgson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

OpenAI-DotNet/BaseResponse.cs Outdated Show resolved Hide resolved
chsword
chsword commented Nov 12, 2023
View reviewed changes
Copy link
Contributor Author

@chsword chsword left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have formatted and modified the code as requested.

@StephenHodgson
Copy link
Member

Thanks! we're close now :)

I think we can make the int values nullable and we're good to go 😎

@chsword
Copy link
Contributor Author

chsword commented Nov 12, 2023

Thanks! we're close now :)

I think we can make the int values nullable and we're good to go 😎

I just submitted the code.

chsword and others added 2 commits November 12, 2023 16:24
@chsword @StephenHodgson
更新 OpenAI-DotNet.csproj
e1886d9 
Co-authored-by: Stephen Hodgson <[email protected]>
@chsword @StephenHodgson
更新 TestFixture_03_Chat.cs
7b9c8b6 
Co-authored-by: Stephen Hodgson <[email protected]>
@chsword @StephenHodgson
更新 BaseResponse.cs
8f4bcec 
Co-authored-by: Stephen Hodgson <[email protected]>
@StephenHodgson
Copy link
Member

one last request and we will merge.

Please update readme with changes from https://github.com/RageAgainstThePixel/OpenAI-DotNet/pull/163/files

@StephenHodgson StephenHodgson merged commit 5de096c into RageAgainstThePixel:main Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephenHodgson StephenHodgson StephenHodgson approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chsword @StephenHodgson