-
-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tool auto generated Invoke reflection names are too long #323
Tool auto generated Invoke reflection names are too long #323
Comments
I faced the same issue.
But how did you do that? I didn't see any accessible ways to specify function name by myself. |
Using hashes or guids would make it a bit more difficult to debug. Part of the reason I haven't implemented it yet |
Needs to be unique, and ideally not something that is super configurable, also the cache uses the names as keys on the backend. |
Maybe it makes sense to separate Tools for different chats. For example, we could create a kind of Tool pool or Tool container. Making this class static provides a simpler way to interact with it, but this approach limits the flexibility of using Tools in scaled production apps. |
You don't have to use the built-in tool serialization convince methods. You can always serialize and pass your own. That is off topic from the issue and not productive to solving the original problem defined in the title. Open a discussion about it if you'd like to talk about proposals like this. The reason it is done this way is to provide convenient way to invoke those same tools if they happen to have locally defined methods you can execute in known libraries. Without mapping these things correctly it'd never work. |
I found that removing this and only including the
method.Name
solved it.I realize it isn't the ideal scenario in case two types contain the same method name, but it would still be helpful with an
omit namespace
option if possible. For now I've been removing it manually here in each update :)Originally posted by @Bodekaer in RageAgainstThePixel/com.openai.unity#235 (comment)
Proposed fix:
Converting long namespace names to hash file string guid.
The text was updated successfully, but these errors were encountered: