Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding vhost into connection string #4

Merged
merged 1 commit into from
Jun 1, 2020
Merged

adding vhost into connection string #4

merged 1 commit into from
Jun 1, 2020

Conversation

wouldgo
Copy link
Contributor

@wouldgo wouldgo commented May 29, 2020 •
edited
Loading

Hi,

I've have multiple clients that are bound on specific vhosts. So I need to specify that option.
I used encodeURIComponent() due to the fact that vhosts must be escaped.

Hope this can help (my requirements for sure 😄),
Dario

@RafaelGSS
Copy link
Owner

Hey @wouldgo thanks for contributing.

Can you add vhost at tests too?

@RafaelGSS RafaelGSS added the enhancement New feature or request label May 30, 2020
@RafaelGSS RafaelGSS merged commit efb0dcf into RafaelGSS:master Jun 1, 2020
@RafaelGSS
Copy link
Owner

I merged, but needs add VHost config at network_mode in circleCI container. When I have time I can do this, and thus generate a new release. However, feel free to send a PR 😄

@RafaelGSS RafaelGSS mentioned this pull request Jun 1, 2020
Open
@wouldgo
Copy link
Contributor Author

wouldgo commented Jun 3, 2020

Did not see tests and other stuff. As soon I can I'll take a look

@RafaelGSS RafaelGSS mentioned this pull request Sep 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wouldgo @RafaelGSS