feat: add API response classes for success and error #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Valentin Sickert <[email protected]>
Signed-off-by: Valentin Sickert <[email protected]>
Signed-off-by: Valentin Sickert <[email protected]>
whyauthentic
approved these changes
Dec 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces standardized API response classes to enhance consistency and clarity in handling server responses. Two classes have been added: one for successful responses (
ApiSuccessResponse) and another for error responses (ApiErrorResponse). These classes encapsulate the necessary information, such as status codes, messages, and additional data, providing a uniform structure for API interactions.By adopting these response classes, we aim to streamline error handling and response processing across the codebase. Developers can now rely on a consistent format when dealing with API responses, promoting better code maintainability and reducing the likelihood of errors related to response parsing.