Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: slicify antpair2ind result #1387

Merged
merged 1 commit into from
Feb 10, 2024
Merged

perf: slicify antpair2ind result #1387

merged 1 commit into from
Feb 10, 2024

Conversation

steven-murray
Copy link
Contributor

@steven-murray steven-murray commented Jan 31, 2024

Description

This simply tries to turn all antpair2ind results into slices. Previously, it would try to turn them into slices to store on the key2ind cache only.

I also restricted pytest to <8.0 for now because of this: pytest-dev/pytest#11868

Motivation and Context

This helps performance, and makes it easier to reason about the output (i.e. it will always be a slice if it possibly can be).

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation change (documentation changes only)
  • Version change
  • Build or continuous integration change

Checklist:

Bug fix checklist:

  • My fix includes a new test that breaks as a result of the bug (if possible).
  • All new and existing tests pass.
  • I have updated the CHANGELOG.

New feature checklist:

  • I have added or updated the docstrings associated with my feature using the numpy docstring format.
  • I have updated the tutorial to highlight my new feature (if appropriate).
  • I have added tests to cover my new feature.
  • All new and existing tests pass.
  • I have updated the CHANGELOG.

Breaking change checklist:

  • I have updated the docstrings associated with my change using the numpy docstring format.
  • I have updated the tutorial to reflect my changes (if appropriate).
  • My change includes backwards compatibility and deprecation warnings (if possible).
  • I have added tests to cover my changes.
  • All new and existing tests pass.
  • I have updated the CHANGELOG.

Documentation change checklist:

  • Any updated docstrings use the numpy docstring format.
  • If this is a significant change to the readme or other docs, I have checked that they are rendered properly on ReadTheDocs. (you may need help to get this branch to build on RTD, just ask!)

Version change checklist:

  • I have updated the CHANGELOG to put all the unreleased changes under the new version (leaving the unreleased section empty).
  • I have noted any dependency changes since the last version and will update the conda package build accordingly.

Build or continuous integration change checklist:

  • If required or optional dependencies have changed (including version numbers), I have updated the readme to reflect this.
  • If this is a new CI setup, I have added the associated badge to the readme and to references/make_index.py (if appropriate).

setup.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (07a3d7c) 99.92% compared to head (521726b) 99.92%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           prep_v3.0    #1387   +/-   ##
==========================================
  Coverage      99.92%   99.92%           
==========================================
  Files             37       37           
  Lines          20967    20966    -1     
==========================================
- Hits           20951    20950    -1     
  Misses            16       16           
Files Coverage Δ
pyuvdata/uvdata/uvdata.py 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07a3d7c...521726b. Read the comment docs.

Copy link
Member

@bhazelton bhazelton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. It looks like this is already reflected in the changelog.

@bhazelton bhazelton merged commit e693391 into prep_v3.0 Feb 10, 2024
46 of 53 checks passed
@bhazelton bhazelton deleted the always-slicify branch February 10, 2024 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants