Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make imports work with current and future pyuvdata, fix compatibility with numpy 2.0 #253

Merged
merged 5 commits into from
Jul 1, 2024

Conversation

bhazelton
Copy link
Member

@bhazelton bhazelton commented Jun 20, 2024

Description

Fix some imports for pyuvdata v3 and fix compatibility with numpy 2.0

Motivation and Context

Checklists:

Bug Fix Checklist:

  • I have read the contribution guide.
  • My code follows the code style of this project.
  • My fix includes a new test that breaks as a result of the bug (if possible).
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible).
  • I have updated the CHANGELOG.

@bhazelton bhazelton added the bug Something isn't working label Jun 20, 2024
@bhazelton bhazelton requested a review from mkolopanis June 20, 2024 18:44
Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (914e399) to head (dbfc8ad).
Report is 21 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #253   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines         2129      2131    +2     
  Branches       608       608           
=========================================
+ Hits          2129      2131    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bhazelton bhazelton force-pushed the pyuvdata_v3_updates branch from a9c8476 to 76cfab7 Compare June 21, 2024 20:26
@bhazelton bhazelton force-pushed the pyuvdata_v3_updates branch from ce36c37 to a60bd26 Compare June 29, 2024 06:29
@bhazelton bhazelton force-pushed the pyuvdata_v3_updates branch from 9806c55 to dbfc8ad Compare June 29, 2024 06:59
@bhazelton bhazelton changed the title Make imports work with current and future pyuvdata Make imports work with current and future pyuvdata, fix compatibility with numpy 2.0 Jun 29, 2024
@bhazelton bhazelton requested a review from jpober June 29, 2024 07:28
@bhazelton bhazelton marked this pull request as ready for review June 29, 2024 07:29
@bhazelton
Copy link
Member Author

The pyuvsim tests are failing because the fix for numpy 2.0 isn't into pyuvsim yet (it's in a PR). This has to be merged and we have to do a release to enable tests to pass on pyuvsim.

Copy link
Member

@jpober jpober left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two coverage warnings in skymodel.py, so I'll approve but not take any steps to merge.

@bhazelton
Copy link
Member Author

I think those warnings are out of date. I just checked on my machine and those lines are definitely hit by tests and the actual codecov CI passed, so I'm going to merge.

@bhazelton bhazelton merged commit 81b1b2e into main Jul 1, 2024
32 of 34 checks passed
@bhazelton bhazelton deleted the pyuvdata_v3_updates branch July 1, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants