-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make imports work with current and future pyuvdata, fix compatibility with numpy 2.0 #253
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #253 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 2129 2131 +2
Branches 608 608
=========================================
+ Hits 2129 2131 +2 ☔ View full report in Codecov by Sentry. |
a9c8476
to
76cfab7
Compare
ce36c37
to
a60bd26
Compare
9806c55
to
dbfc8ad
Compare
The pyuvsim tests are failing because the fix for numpy 2.0 isn't into pyuvsim yet (it's in a PR). This has to be merged and we have to do a release to enable tests to pass on pyuvsim. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are two coverage warnings in skymodel.py, so I'll approve but not take any steps to merge.
I think those warnings are out of date. I just checked on my machine and those lines are definitely hit by tests and the actual codecov CI passed, so I'm going to merge. |
Description
Fix some imports for pyuvdata v3 and fix compatibility with numpy 2.0
Motivation and Context
Checklists:
Bug Fix Checklist: