Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JOSS reference #247

Merged
merged 2 commits into from
Jun 4, 2024
Merged

Add JOSS reference #247

merged 2 commits into from
Jun 4, 2024

Conversation

bhazelton
Copy link
Member

Description

Add citation information for our JOSS paper to the readme.

Motivation and Context

Checklists:

Documentation Change Checklist:

@bhazelton bhazelton added the documentation Improvements or additions to documentation label May 29, 2024
@bhazelton bhazelton requested a review from jpober May 29, 2024 23:55
Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (88932f3) to head (4c10c73).
Report is 25 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #247   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines         2131      2131           
  Branches       608       608           
=========================================
  Hits          2131      2131           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jpober jpober left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, so I approve. But tests are failing and I can never keep track of when that's expected and when that's not...

@bhazelton bhazelton requested a review from jpober June 4, 2024 19:53
@bhazelton bhazelton merged commit 119ba99 into main Jun 4, 2024
34 checks passed
@bhazelton bhazelton deleted the add_joss_ref branch June 4, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants