Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use authorization header instead of adding to query #128

Merged
merged 3 commits into from
Jul 25, 2024
Merged

Conversation

Radiicall
Copy link
Owner

This should avoid some logging issues when reporting bugs and also up the general security of the requests

This should avoid some logging issues when reporting bugs and also up the general security of the requests
@Radiicall
Copy link
Owner Author

Radiicall commented Jul 24, 2024

@EmeryxWildfire Do you still have an emby server that you can test this on?

I need someone to test this on Emby

@Radiicall
Copy link
Owner Author

Package with new auth can be found at the bottom of this page

@Radiicall Radiicall added the help wanted Extra attention is needed label Jul 25, 2024
@Nathan5471
Copy link

I tried it on an Emby server and it worked with a movie, is there something specific that needed to be tested?

@Radiicall
Copy link
Owner Author

I tried it on an Emby server and it worked with a movie, is there something specific that needed to be tested?

Hey that's perfect thanks! I am testing a new way to do the authentication but I had to confirm that the solution i put in place for emby actually works

@Radiicall Radiicall merged commit b372914 into main Jul 25, 2024
6 checks passed
@Radiicall Radiicall deleted the authorization branch July 26, 2024 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants