Add OnDelete Notification to TraktConnection #4869
Conversation
|
@Qstick OnDelete could be useful for other connections as well, but if we're going to add an initialization sync + re-sync option, it may make sense to move this over to a new Integrations tab. |
|
Yea, that was the plan to add onDelete to all, integrations isn’t something for v3 we are trying to get it pushed out. So I’d leave the sync out of this for now. |
src/NzbDrone.Core/Notifications/Trakt/Resource/TraktCollectMoviesResource.cs
Outdated
Show resolved
Hide resolved
src/NzbDrone.Core/Datastore/Migration/180_on_delete_notification.cs
Outdated
Show resolved
Hide resolved
frontend/src/Settings/Notifications/Notifications/NotificationEventItems.js
Show resolved
Hide resolved
src/NzbDrone.Core/Datastore/Migration/182_on_delete_notification.cs
Outdated
Show resolved
Hide resolved
|
Looking good, can you just add the unit test case for onDelete to |
I added the unit tests but I'm not 100% sure I did it properly. I think so, but let me know if I went wrong. |
|
Can you squash this down to one or two logical commits. Also use |
to remove movies from Trakt Collection when they are removed from Radarr Add OnDelete Notification to TraktConnection to remove movies from Trakt Collection when they are removed from Radarr skip the deleteHandler if the delete Event was triggered for reason: Upgrade change migration from 180 to 182 since 180 and 181 are already in plan to be used address comments regarding helpText for OnDelete and move check for OnUpgrade deletion reason into trakt connection OnDelete handler reuse TraktCollectMoviesResource for OnDelete trakt api should just ignore the other properties anyway add WithDefaultValue to migration add unit test case for onDelete to fix unit testcase for onDelete
Database Migration
YES - needed to add migration 182 --> on_delete_notification
Description
This will notify Trakt to remove an item from Collection when a movie file is deleted. On delete must be selected and enabled for the Trakt Connection
Todos
Issues Fixed or Closed by this PR
#4521
Another feature still needs to be implemented. A button to manually trigger a full sync should be added still - that will be handled in a different PR in the future.