-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ipmi-user-list catalog data #523
Conversation
b6c9b67
to
b16603c
Compare
The Copyright Check has failed!
|
@geoff-reid , @keedya any changes needed here? The copyright check failed on a a pre-existing file, but I can update that if you want. |
@gavin-scott could you fix the Copyright failure? |
The Copyright Check has failed!
|
78f7cd6
to
82dd5ec
Compare
@lanchongyizu sorry for delay, I added the copyright message to |
@gavin-scott Sorry for the delay. The concourse fail case is as below, which I think is caused by concourse instability. Could you push a new commit to trigger the concourse again?
|
Code that parsed `sudo ipmitool -c user list N` assumed there would be a header row printed and built the user hash keys from the first line. However `ipmitool user list` only prints the headers when invoked without `-c` which puts it into CSV output mode. When invoked with `-c` there is no header line and the first user was getting eaten up and treated as the header. Example ipmitool output: monorail@monorail-micro:~$ sudo ipmitool user list 1 ID Name Callin Link Auth IPMI Msg Channel Priv Limit 2 root true true true ADMINISTRATOR monorail@monorail-micro:~$ sudo ipmitool user -c list 1 2,root,true,true,true,ADMINISTRATOR This fix hard-codes the header values as the header that is printed when invoked without `-c` looks nigh-impossible to parse. The previous code was also eating the first user because that line was taken as the header line.
82dd5ec
to
9630872
Compare
Sure @lanchongyizu -- just did. |
Code that parsed
sudo ipmitool -c user list N
assumed therewould be a header row printed and built the user hash keys from
the first line. However
ipmitool user list
only prints theheaders when invoked without
-c
which puts it into CSV outputmode. When invoked with
-c
there is no header line and thefirst user was getting eaten up and treated as the header.
Example ipmitool output:
This fix hard-codes the header values as the header that is
printed when invoked without
-c
looks nigh-impossible toparse. The previous code was also eating the first user because
that line was taken as the header line.