-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAG-289 [ORFS-97] Add create delete raid graph #34
Conversation
var base = require('./base-graph-spec'); | ||
|
||
base.before(function (context) { | ||
context.taskdefinition = helper.require('/lib/graphs/delete-megaraid-graph.js'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'helper' is not defined.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hound doesn't mark global.helper as a lint exception.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Figured it out, hound is not reading our test .jshintrc in the spec directory houndci/hound#889
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @benbp. Good to know this kind of info
b6c08ff
to
af82c3e
Compare
👍 |
1 similar comment
👍 |
MAG-289 [ORFS-97] Add create delete raid graph
Add reset and soft reset IPMI/OBM support
…ut to master * commit 'ad150d9bd0d3d00064ad2fa9ae8fcac1b164f2a5': fix typo adding additional error catching to identify missing stdout on data callback to parser
Fix OBM lookups for wsman scp configuration jobs.
This PR is to add graph for create or delete raid then refresh the MegaRAID catalog
Dependency PR RackHD/on-tasks#76
@RackHD/corecommitters @iceiilin @pengz1 @sunnyqianzhang