Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAG-289 [ORFS-97] Add create delete raid graph #34

Merged
merged 1 commit into from
Dec 3, 2015

Conversation

WangWinson
Copy link
Contributor

This PR is to add graph for create or delete raid then refresh the MegaRAID catalog
Dependency PR RackHD/on-tasks#76

@RackHD/corecommitters @iceiilin @pengz1 @sunnyqianzhang

var base = require('./base-graph-spec');

base.before(function (context) {
context.taskdefinition = helper.require('/lib/graphs/delete-megaraid-graph.js');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'helper' is not defined.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hound doesn't mark global.helper as a lint exception.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Figured it out, hound is not reading our test .jshintrc in the spec directory houndci/hound#889

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @benbp. Good to know this kind of info

@WangWinson WangWinson force-pushed the feature/create-delete-raid branch from b6c08ff to af82c3e Compare December 2, 2015 10:34
@benbp
Copy link
Contributor

benbp commented Dec 2, 2015

👍

1 similar comment
@yyscamper
Copy link
Contributor

👍

yyscamper added a commit that referenced this pull request Dec 3, 2015
MAG-289 [ORFS-97] Add create delete raid graph
@yyscamper yyscamper merged commit c74b17c into RackHD:master Dec 3, 2015
sushilrai pushed a commit to sushilrai/on-taskgraph that referenced this pull request Dec 5, 2017
Add reset and soft reset IPMI/OBM support
sushilrai pushed a commit to sushilrai/on-taskgraph that referenced this pull request Dec 5, 2017
…ut to master

* commit 'ad150d9bd0d3d00064ad2fa9ae8fcac1b164f2a5':
  fix typo
  adding additional error catching to identify missing stdout on data callback to parser
sushilrai pushed a commit to sushilrai/on-taskgraph that referenced this pull request Dec 5, 2017
Fix OBM lookups for wsman scp configuration jobs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants