Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support of sunblinds in the thermal zone model #543

Closed
2 of 3 tasks
MichaMans opened this issue Oct 25, 2018 · 2 comments
Closed
2 of 3 tasks

Support of sunblinds in the thermal zone model #543

MichaMans opened this issue Oct 25, 2018 · 2 comments
Assignees

Comments

@MichaMans
Copy link
Contributor

MichaMans commented Oct 25, 2018

What is the problem?

  • The advanced model of the aixlib thermal zone supports sunblinds, we should support that

Why do we want to solve it?

  • This enhances the simulation a lot

How do we want to solve it?

  • Check maximum solar irradiation limit when sunblind closes in window class and material type
  • Check shading factor if sunblind is closed
  • Integrate both factors in the AixLib Multizone Template
@MichaMans MichaMans self-assigned this Oct 25, 2018
MichaMans added a commit that referenced this issue Oct 25, 2018
…g factor, added shading_max_irr and shading_g_total to record export, attention hardcode
@PRemmen PRemmen self-assigned this Nov 28, 2019
@MartinRaetz
Copy link
Contributor

MartinRaetz commented Nov 28, 2019

I want to add my conclusion of the present state of the development regarding this sunblind issue:

There are unused parameter in the TypeBuildingElements Json files.

  • "shading_max_irr"
  • "shading_g_total"

The WindowElement parameter "shading_max_irr" is not passed on in Teaser.
"Shading_g_total" will be converted to "g_sunblind" but is also not passed on anymore.

In the Modelica AixLib there is then a variable in the "PartialVDI6007" model named "sunblind" which is passed over by the connector and set by a constant source. This "sunblind" parameter reduces the "Equivalent long wave temperature for windows" by the corresponding sunblind factor. Put simply, if sunblind = 1 no long wave radiation penetrates the room, if sunblind = 0 the complete long wave radiation enters the room.

The "sunblind" parameter is statically set to zero, no other value from the database sheets influences it.
Excerpt from Modelicas ThermalZone Class:

  • Modelica.Blocks.Sources.Constant constSunblindWall[zoneParam.nOrientations](each k=0) "Sets sunblind signal to zero (open)";
  • Modelica.Blocks.Sources.Constant constSunblindRoof[zoneParam.nOrientationsRoof]
    (each k=0) "Sets sunblind signal to zero (open)";

Suggestions:

  1. Delete the values from the TypeBuildingElements Json´s to reduce the complexity and do not mislead the user.
  2. Implement the full use of sunblinds. In that case it should be discussed, whether the use of sunblinds should be defined with the used window type (TypeBuildingElements) or with the respective UsageType (UseConditions), or even in another way.

@PRemmen proposed the following 3 step approach:

  1. shading_max_irr in die Berechnungen aufnehmen (logic.buildingsobjects.calculation), damit der alle schwellenwerte für alle Fenster und zonen sammelt
  2. Im Modell ThermalZoneEquipped den constanten block (constSunblindWall) durch einen Switch ersetzen der als schwellwert shading_max_irr hat und in eqAirTemp einfließt (hier wird die absortption der kurzwelligen strhalung berechnet)
  3. Den output ebenfalls in das Modell corGMod in ThermalZoneEquipped einführen, da dort die transmission der kurzwelligen Strahlung durch das Fenster berücksichtigt wird

@PRemmen
Copy link
Member

PRemmen commented Apr 17, 2020

@MartinRaetz I actually solved this issue :) see #634

MartinRaetz added a commit that referenced this issue Jun 16, 2021
* #543 changed shading g total to 1 for the use for the sunblind shading factor, added shading_max_irr and shading_g_total to record export, attention hardcode

* #543 changed sunblind parameters to be usecondition parameters

* boundary conditions are not needed any longer

* just black

* untested proposal for shading gvalue

* fix calculation of shading

* #635 should revise the setters

* Update doc strings and mark todos

* Add value for max power of ideal cooler

* Typo in doc string

* Improvements excel import

* Update air density typo

* added info to doc string conv_rad

* Improvements excel import

* revert part of a commit that accidently had these changes

* run black on exvel import

* add info

* delete blank line

* restart ci

* Revert "restart ci"

This reverts commit 6253f74.

* add document suggestions made by @MartinRaetz

* defaults to 1.0 if now windows

* More doc strings extensions

* More doc strings extensions 2

* WithProfile commit

* schedules is private attribute (doc string)

* Format

* Correct and reformulate withProfile docstrings

* Correct and reformulate withProfile docstrings

* correct "nan-dealing" and update pandas df.at to df.loc and typing error

* update pandas df.at to df.loc

* update parameter names based on MBL

* add moisture and nports to RC models

* add 0 time step to internal gains

* set columns in gains file to 4

* set humidification to false if central_ahu

* change shading default

* remove hacked moisure and nports

* Adds UseCondition for classrooms

* update aixlib model to CO2 multizone

* propagate use_c_flow and set medium with c

* make example import use co2 and moisture balance

* update thermal zone name

* delete probable clutter

* E261 at least two spaces before inline comment

* update for aixlib PR1052

* update buildings version

* Issue566weatherfile (#664)

* first changes

* weird things happening in git

* Revert "weird things happening in git"

This reverts commit 923747b.

* implement working version of weather file export

* delete trial results

* convert everything to: saving weather file at "project" level and not at building level

* Revert "Merge branch 'issue566weatherfile' into development"

This reverts commit 9e772fbff69fbce8711cf3629f0aec4eea0363c3.

* Revert "Revert "Merge branch 'issue566weatherfile' into development""

This reverts commit e376eec.

* blank lines (ci)

* run Black on project.py

* update unitTest.json -> previous weatherfile is outdated (doesnt work for AixLib Version) -> set to None(null) to use default weatherfile of Teaser

* naming

* naming

* Weather file line is to long resulting in error

* First try of IBPSA Weather file export

* fixing

* blank line end of file

* #566 fixed tab stop at end of file

* 566 raised aixlib version number to actual dev number

Co-authored-by: MichaMans <[email protected]>

* Add annotation

For #669

* Write test scripts

For #669

* Add script to run unit tests

For #669

* Option to export reference results

For #669

* Remove test line

For #669

* Use runUnitTests from IBPSA

For #669

* Replace very old version

For #669

* Adjust model path in test script

For #669

* Add missing comma

For #669

* Add missing tolerance

For #669

* Fix decoding errors

For #669

* Deactivate pedantic mode

For #669

* Adjust annotation

For #669

* Change script location

* Delete stray bracket

* Add missing quotes

* Increase count

* revised project name of e3, revised and reformatted runUnitTests.py, added pytest simulaiton export

* revised formatting of aixlib_ouput.py

* added reference results for e2 and added them to the ref path of that example

* Add missing file to setup

For #669

* Adjusted the profiles to a uniform 24h-Format

* solve export problem

* #688 raised version number for master merge

* #688 raise AixLib version number + sort import section following pep8

Co-authored-by: MichaMans <[email protected]>
Co-authored-by: Peter Remmen <[email protected]>
Co-authored-by: Peter Remmen <[email protected]>
Co-authored-by: Nicholas Long <[email protected]>
Co-authored-by: Nicholas Long <[email protected]>
Co-authored-by: Nicholas Long <[email protected]>
Co-authored-by: Martin Kremer <[email protected]>
Co-authored-by: Michael Mans <[email protected]>
Co-authored-by: Martin Kremer <[email protected]>
Co-authored-by: Marcus Fuchs <[email protected]>
Co-authored-by: Wackerbauer <[email protected]>
Co-authored-by: David Wackerbauer <[email protected]>
Co-authored-by: David <[email protected]>
Co-authored-by: David Jansen <[email protected]>
pseiwert pushed a commit that referenced this issue Feb 3, 2023
* #543 changed shading g total to 1 for the use for the sunblind shading factor, added shading_max_irr and shading_g_total to record export, attention hardcode

* #543 changed sunblind parameters to be usecondition parameters

* boundary conditions are not needed any longer

* just black

* untested proposal for shading gvalue

* fix calculation of shading

* #635 should revise the setters

* Update doc strings and mark todos

* Add value for max power of ideal cooler

* Typo in doc string

* Improvements excel import

* Update air density typo

* added info to doc string conv_rad

* Improvements excel import

* revert part of a commit that accidently had these changes

* run black on exvel import

* add info

* delete blank line

* restart ci

* Revert "restart ci"

This reverts commit 6253f74.

* add document suggestions made by @MartinRaetz

* defaults to 1.0 if now windows

* More doc strings extensions

* More doc strings extensions 2

* WithProfile commit

* schedules is private attribute (doc string)

* Format

* Correct and reformulate withProfile docstrings

* Correct and reformulate withProfile docstrings

* correct "nan-dealing" and update pandas df.at to df.loc and typing error

* update pandas df.at to df.loc

* update parameter names based on MBL

* add moisture and nports to RC models

* add 0 time step to internal gains

* set columns in gains file to 4

* set humidification to false if central_ahu

* change shading default

* remove hacked moisure and nports

* Adds UseCondition for classrooms

* update aixlib model to CO2 multizone

* propagate use_c_flow and set medium with c

* make example import use co2 and moisture balance

* update thermal zone name

* delete probable clutter

* E261 at least two spaces before inline comment

* update for aixlib PR1052

* update buildings version

* Issue566weatherfile (#664)

* first changes

* weird things happening in git

* Revert "weird things happening in git"

This reverts commit 923747b.

* implement working version of weather file export

* delete trial results

* convert everything to: saving weather file at "project" level and not at building level

* Revert "Merge branch 'issue566weatherfile' into development"

This reverts commit 9e772fbff69fbce8711cf3629f0aec4eea0363c3.

* Revert "Revert "Merge branch 'issue566weatherfile' into development""

This reverts commit e376eec.

* blank lines (ci)

* run Black on project.py

* update unitTest.json -> previous weatherfile is outdated (doesnt work for AixLib Version) -> set to None(null) to use default weatherfile of Teaser

* naming

* naming

* Weather file line is to long resulting in error

* First try of IBPSA Weather file export

* fixing

* blank line end of file

* #566 fixed tab stop at end of file

* 566 raised aixlib version number to actual dev number

Co-authored-by: MichaMans <[email protected]>

* Add annotation

For #669

* Write test scripts

For #669

* Add script to run unit tests

For #669

* Option to export reference results

For #669

* Remove test line

For #669

* Use runUnitTests from IBPSA

For #669

* Replace very old version

For #669

* Adjust model path in test script

For #669

* Add missing comma

For #669

* Add missing tolerance

For #669

* Fix decoding errors

For #669

* Deactivate pedantic mode

For #669

* Adjust annotation

For #669

* Change script location

* Delete stray bracket

* Add missing quotes

* Increase count

* revised project name of e3, revised and reformatted runUnitTests.py, added pytest simulaiton export

* revised formatting of aixlib_ouput.py

* added reference results for e2 and added them to the ref path of that example

* Add missing file to setup

For #669

* Adjusted the profiles to a uniform 24h-Format

* solve export problem

* #688 raised version number for master merge

* #688 raise AixLib version number + sort import section following pep8

Co-authored-by: MichaMans <[email protected]>
Co-authored-by: Peter Remmen <[email protected]>
Co-authored-by: Peter Remmen <[email protected]>
Co-authored-by: Nicholas Long <[email protected]>
Co-authored-by: Nicholas Long <[email protected]>
Co-authored-by: Nicholas Long <[email protected]>
Co-authored-by: Martin Kremer <[email protected]>
Co-authored-by: Michael Mans <[email protected]>
Co-authored-by: Martin Kremer <[email protected]>
Co-authored-by: Marcus Fuchs <[email protected]>
Co-authored-by: Wackerbauer <[email protected]>
Co-authored-by: David Wackerbauer <[email protected]>
Co-authored-by: David <[email protected]>
Co-authored-by: David Jansen <[email protected]>
pseiwert pushed a commit that referenced this issue Feb 3, 2023
* #543 changed shading g total to 1 for the use for the sunblind shading factor, added shading_max_irr and shading_g_total to record export, attention hardcode

* #543 changed sunblind parameters to be usecondition parameters

* boundary conditions are not needed any longer

* just black

* untested proposal for shading gvalue

* fix calculation of shading

* #635 should revise the setters

* Update doc strings and mark todos

* Add value for max power of ideal cooler

* Typo in doc string

* Improvements excel import

* Update air density typo

* added info to doc string conv_rad

* Improvements excel import

* revert part of a commit that accidently had these changes

* run black on exvel import

* add info

* delete blank line

* restart ci

* Revert "restart ci"

This reverts commit 6253f74.

* add document suggestions made by @MartinRaetz

* defaults to 1.0 if now windows

* More doc strings extensions

* More doc strings extensions 2

* WithProfile commit

* schedules is private attribute (doc string)

* Format

* Correct and reformulate withProfile docstrings

* Correct and reformulate withProfile docstrings

* correct "nan-dealing" and update pandas df.at to df.loc and typing error

* update pandas df.at to df.loc

* update parameter names based on MBL

* add moisture and nports to RC models

* add 0 time step to internal gains

* set columns in gains file to 4

* set humidification to false if central_ahu

* change shading default

* remove hacked moisure and nports

* Adds UseCondition for classrooms

* update aixlib model to CO2 multizone

* propagate use_c_flow and set medium with c

* make example import use co2 and moisture balance

* update thermal zone name

* delete probable clutter

* E261 at least two spaces before inline comment

* update for aixlib PR1052

* update buildings version

* Issue566weatherfile (#664)

* first changes

* weird things happening in git

* Revert "weird things happening in git"

This reverts commit 923747b.

* implement working version of weather file export

* delete trial results

* convert everything to: saving weather file at "project" level and not at building level

* Revert "Merge branch 'issue566weatherfile' into development"

This reverts commit 9e772fbff69fbce8711cf3629f0aec4eea0363c3.

* Revert "Revert "Merge branch 'issue566weatherfile' into development""

This reverts commit e376eec.

* blank lines (ci)

* run Black on project.py

* update unitTest.json -> previous weatherfile is outdated (doesnt work for AixLib Version) -> set to None(null) to use default weatherfile of Teaser

* naming

* naming

* Weather file line is to long resulting in error

* First try of IBPSA Weather file export

* fixing

* blank line end of file

* #566 fixed tab stop at end of file

* 566 raised aixlib version number to actual dev number

Co-authored-by: MichaMans <[email protected]>

* Add annotation

For #669

* Write test scripts

For #669

* Add script to run unit tests

For #669

* Option to export reference results

For #669

* Remove test line

For #669

* Use runUnitTests from IBPSA

For #669

* Replace very old version

For #669

* Adjust model path in test script

For #669

* Add missing comma

For #669

* Add missing tolerance

For #669

* Fix decoding errors

For #669

* Deactivate pedantic mode

For #669

* Adjust annotation

For #669

* Change script location

* Delete stray bracket

* Add missing quotes

* Increase count

* revised project name of e3, revised and reformatted runUnitTests.py, added pytest simulaiton export

* revised formatting of aixlib_ouput.py

* added reference results for e2 and added them to the ref path of that example

* Add missing file to setup

For #669

* Adjusted the profiles to a uniform 24h-Format

* solve export problem

* #688 raised version number for master merge

* #688 raise AixLib version number + sort import section following pep8

Co-authored-by: MichaMans <[email protected]>
Co-authored-by: Peter Remmen <[email protected]>
Co-authored-by: Peter Remmen <[email protected]>
Co-authored-by: Nicholas Long <[email protected]>
Co-authored-by: Nicholas Long <[email protected]>
Co-authored-by: Nicholas Long <[email protected]>
Co-authored-by: Martin Kremer <[email protected]>
Co-authored-by: Michael Mans <[email protected]>
Co-authored-by: Martin Kremer <[email protected]>
Co-authored-by: Marcus Fuchs <[email protected]>
Co-authored-by: Wackerbauer <[email protected]>
Co-authored-by: David Wackerbauer <[email protected]>
Co-authored-by: David <[email protected]>
Co-authored-by: David Jansen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants