1417 include swimming pool in rom as a moisture source #1457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to 1417-include-swimming-pool-in-rom-as-a-moisture-source
…to 1417-include-swimming-pool-in-rom-as-a-moisture-source
…to 1417-include-swimming-pool-in-rom-as-a-moisture-source
…g-pool-in-rom-as-a-moisture-source
…a-moisture-source
…model to enable evaporation to ROM
…el (swimming facility)
…ion reference files.Please pull the new files before push again. Plottet Results https://ebc.pages.rwth-aachen.de/EBC_all/github_ci/AixLib/1417-include-swimming-pool-in-rom-as-a-moisture-source/plots/
…a-moisture-source
|
Errors in regression test. Compare the results on the following page |
…ion reference files.Please pull the new files before push again. Plottet Results https://ebc.pages.rwth-aachen.de/EBC_all/github_ci/AixLib/1417-include-swimming-pool-in-rom-as-a-moisture-source/plots/
… facility and create new ref results
…m-as-a-moisture-source' into 1417-include-swimming-pool-in-rom-as-a-moisture-source
…ion reference files.Please pull the new files before push again. Plottet Results https://ebc.pages.rwth-aachen.de/EBC_all/github_ci/AixLib/1417-include-swimming-pool-in-rom-as-a-moisture-source/plots/
…a-moisture-source
…a-moisture-source
alexanderAKU
approved these changes
Oct 23, 2023
larissakuehn
deleted the
1417-include-swimming-pool-in-rom-as-a-moisture-source
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Within this branch the pool model AixLib.Fluid.Pools.IndoorSwimmingPool was integrated into AixLib.ThermalZones.ReducedOrder.ThermalZone.ThermalZone as described in issue #1417.
The model for the building itself is part of the IBPSA library and can therefore not be changed (AixLib.ThermalZones.ReducedOrder.RC.FourElements). Because of this we could not change the input port QLat_flow. The port enables heatflow and moisture input, but only at a constant predefined temperture. Because of this we included the model AixLib.Fluid.Pools.BaseClasses.AirFlowMoistureToROM with an extra air volume and an air exchange to the actual air volume of the building model.
We included to examples to demonstrate the usage of the model for the simulation of a swimming hall (AixLib.ThermalZones.ReducedOrder.Examples.ThermalZoneMoistAirSwimmingPool) and a whole swimming facility (AixLib.ThermalZones.ReducedOrder.Examples.MultizoneMoistAirCO2EquippedSwimmingFacility) with examplary records for a standard swimming facility (AixLib.DataBase.ThermalZones.SwimmingFacility) including to swimming pools (AixLib.DataBase.Pools).