1367 geothermalheatpump example fails in openmodelica #1441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lheatpump-example-fails-in-openmodelica
FWuellhorst
requested changes
Jun 6, 2023
AixLib/Fluid/Examples/GeothermalHeatPump/BaseClasses/GeothermalHeatPumpBase.mo
Show resolved
Hide resolved
AixLib/Fluid/Examples/GeothermalHeatPump/BaseClasses/GeothermalHeatPumpBase.mo
Outdated
Show resolved
Hide resolved
|
Errors in regression test. Compare the results on the following page |
…ion reference files.Please pull the new files before push again. Plottet Results https://ebc.pages.rwth-aachen.de/EBC_all/github_ci/AixLib/1367-geothermalheatpump-example-fails-in-openmodelica/plots/
|
The previous pipelines failed due to another, not already solved, problem with the |
HannahRomberg
commented
Jul 17, 2023
HannahRomberg
deleted the
1367-geothermalheatpump-example-fails-in-openmodelica
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1367
The flow direction from the cold storage to the evaporator was going in the wrong direction. The heating coil orientation was changed to down->up and the port connections were changed to allow the flow in the right direction.