Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor confusing names of heat pump safety models #1128

Closed
Tracked by #1520
FWuellhorst opened this issue May 21, 2021 · 2 comments · Fixed by #1532
Closed
Tracked by #1520

Refactor confusing names of heat pump safety models #1128

FWuellhorst opened this issue May 21, 2021 · 2 comments · Fixed by #1532
Assignees
@FWuellhorst
Labels
hackday

Comments

@FWuellhorst
Copy link
Contributor

The current heat pump controllers have two OnOff models: One to control the compressor, one that decides if operation is safe.

Refactoring to avoid confusing is necessary. Any ideas for different names?

Affected models:

  • AixLib.Controls.HeatPump.BaseClasses.OnOffHP
  • AixLib.Controls.HeatPump.HPControllerOnOff
  • AixLib.Controls.HeatPump.SafetyControls.OnOffControl
@FWuellhorst FWuellhorst self-assigned this May 21, 2021
@FWuellhorst FWuellhorst mentioned this issue May 21, 2021
Merged
3 tasks
@tobinfiedler
Copy link
Contributor

@FWuellhorst Is this issue still current?

@FWuellhorst
Copy link
Contributor Author

I will use TwoPoint Controlled Heat Pump as a name

FWuellhorst pushed a commit that referenced this issue Jul 14, 2022
Add scripts, rename, remove old files #1128
2ab5414
@FWuellhorst FWuellhorst mentioned this issue Jul 14, 2022
Closed
@FWuellhorst FWuellhorst mentioned this issue Jul 26, 2024
Closed
9 tasks
FWuellhorst added a commit that referenced this issue Aug 21, 2024
@FWuellhorst
add changes from #1128 and #1302 to this branch
abb6d72
@FWuellhorst FWuellhorst mentioned this issue Aug 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FWuellhorst FWuellhorst

Labels
hackday
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

1520 new hp models RWTH-EBC/AixLib
Add scripts, rename, remove old files #1128 RWTH-EBC/AixLib
3 participants
@FWuellhorst @larissakuehn @tobinfiedler