Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Schedule overhaul, filtering changes, bug fixes. #19

Open
wants to merge 47 commits into
base: master
Choose a base branch
from
Open

Schedule overhaul, filtering changes, bug fixes. #19

wants to merge 47 commits into from

Conversation

Micrified
Copy link
Collaborator

@Micrified Micrified commented Jun 8, 2018 •
edited
Loading

This PR includes the following important changes.

  • Repositioned menu bar icons to match Android version.
  • Added filtering for General Information data. Now shows just school specific + admin info.
  • Added filtering for Lecturer data. Now shows just school specific lecturers.
  • Corrupt entries in JSON data arrays are ignored, and do not cause rejection of good entries.
  • Added a Admin/Coordinator tag to General Information items.
  • Overhauled the schedule. It now allows for paging between weeks, and looks more like a calendar.
  • Fixed bug where the app would crash if the school it was registered under was deleted after sign in.
  • Added synchronous requests for serial fetching in background threads, and overhauled data-fetching routine for the schedule (previously was inefficient).
  • Fixed bug where the Credits screen had disappeared.
  • Fixed anomaly where separators in the General Information view weren't showing.
  • Adjusted the forum thread submission form so that it automatically enables the submit button when enough text is entered, not just after finalizing the message.

@Micrified
Partial refactoring underway
b3d5c56
@Micrified
Update to data loading routines for forum threads and comments.
d35e8fc
@Micrified
The server update has truly thrown me in despair...
39162b9
@Micrified
Added school name to settings. Updated login system scheme. Removed f…
00dfa82 
…atal crashes in parser routines. Many more updates.
@Micrified
Removing comments from persistent storage.
5a1f21f
@Micrified
Login fixed. School Info acquisition in.
d25796c
@Micrified
Small changes.
1ac44fb
@Micrified
Comment submission + deletion. Thread deletion + submission work. Aut…
9eff942 
…hentication improvements.
@Micrified
Announcement author's removed. Adjustments to forum. Fixes to other J…
448911b 
…SON.
@Micrified
Added placeholder text behavior for UITextView.
52d3829
@Micrified
Refactored LecturerDataModel, various other changes.
1e296b1
@Micrified
Fixed Facebook login. Added School verification on start. Adjusted le…
b74703e 
…cturers.
@Micrified
Removed email login as an option.
9f74dc5
@Micrified
Added in early splash screen for school selection.
6399d29
@Micrified
Added School Name login page + error handling. Refactored background …
dfca0e1 
…thread routines for secondary resources to avoid exceptions.
@Micrified
Dead code removal, hardening, and error fixes.
3cf98c0
@Micrified
Fixed event sorting in calendar. Re-implemented sections.
3df13de
@Micrified
Added smoother reload animations for General Info and Announcements
a594b82
@Micrified
Added smooth reload animation for lecturers and schedule.
0577e06
@Micrified
Added missing files.
fbc5c17
@Micrified
Placeholder for NIL images added. Fixes unwanted behavior where users…
f69ba61 
… with no profile images get others from recycled cells.
@Micrified
Filtering by school fix.
c673d4e
@Micrified
Removed lock screen bypass from settings.
1b74592
@Micrified
Attempt to remove warning messages.
6b07661
@Micrified
Removed frameworks + sensitive config files
f6ff932
@Micrified
Updated read.
b379231
@Micrified
Minor edit.
cd2e4d4
@Micrified
Login popup moves to avoid keyboard. School Info screen now has clear…
be62cd3 
… options. Credits added. Weird schedule table bug removed.
@Micrified
Major schedule bug fixed. Reconfigured Firebase.
49dab88
@Micrified
Fixed announcement icon on iPhone 7+
6f00aa3
Micrified and others added 17 commits April 28, 2018 14:08
@Micrified
Adjusted bug where popup clears input on login. Implemented fake user…
705df25 
…name field.
@Micrified
Fixed lecturer image URL bug.
85b0c2f
@Micrified
Image fix, installed crashlytics. Looks like I can't validate though …
d22bbb1 
…- just got marked an obsolete version of macOS. End of the line for 10.11.6.
@Micrified
Upgraded all pods, Xcode 9 installation
17b2972
@Micrified
Update methods, added logging, fixed threading bug
892fec6
Fixed bug where deleted school caused app to crash on verification.
f246e75
Added new date formatting methods to dateManager, fixed typo in RGSLe…
1ab0b6e 
…cturerViewController
Submit button for new forum threads now enables itself during editing.
506f171
Updated order of tab-bar items to match the Android app.
3b46931
Lecturers are now filtered as requested. Individual corrupted entries…
568bb0c 
… no longer cause entire JSON arrays to be dropped. Just those particular entries.
Fixed Credits panel (for some reason it had been wiped).
e4bb3b2
Fixed bug where I wasn't calling super.layoutSubviews in various cust…
5927448 
…om cell classes. Added general info filtering as specified by customer.
Visiting the forum tab automatically triggers a refresh.
73824e0
Fixed issue where Announcements wasn't filtered after initial sign in…
b53950f 
…, exposing other announcement info.
Removed print statements in main ViewControllers. Removed blurred bac…
1749641 
…kground effect from sign in.
Fetching URL for schedule events has been adjusted to fix an anomaly …
9a90497 
…where certain events weren't showing.
Added month label in schedule.
097b0de
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Micrified