-
Notifications
You must be signed in to change notification settings - Fork 623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEA: add RecVAE model #727
Conversation
Update: Update code to the latest version
Update: Update code to the latest version
Update code
Update code 2.10
@Sherry-XLL Nice work! I have a question though: The RecVAE repo says
With a link to a different branch. Which branch did you base your code on? Unfortunately the repo doesn't explain the differences explicitly. I'm curious if you figured it out while implementing it. |
@deklanw First of all, thank you very much for your attention to our RecVAE code, which is based on the github link given in the paper at https://github.com/ilya-shenbin/RecVAE. As for the current model and the original code mentioned in the RecVAE repo, there is no essential difference between them. The paper’s description of the model implementation is based on the original ipython notebook, which is convenient for debugging and outputting the paper results. In order to encapsulate the code into a complete project, the model in this repo uses three classes including Encoder, CompositePrior and VAE to modularize the source code, and this is the reason why we use the code in this repo as a reference. |
@Sherry-XLL I see, thanks. So it was just refactoring a notebook into cleaner modules? Idk how close to finished this PR is, but just looking through the code I've noticed a few things:
|
Thank you very much for your attention and kindly corrections, we will improve the RecVAE code this week. |
No description provided.