fix: add \n for addr2line hint

RT-Thread · Jan 8, 2025 · 97b9cc5 · 97b9cc5
1 parent 9ceb17f
commit 97b9cc5
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/components/lwp/lwp.c b/components/lwp/lwp.c
@@ -583,12 +583,12 @@ rt_err_t lwp_backtrace_frame(rt_thread_t uthread, struct rt_hw_backtrace_frame *
         argv = lwp_get_command_line_args(lwp);
         if (argv)
         {
-            rt_kprintf("please use: addr2line -e %s -a -f", argv[0]);
+            rt_kprintf("please use: addr2line -e %s -a -f\n", argv[0]);
             lwp_free_command_line_args(argv);
         }
         else
         {
-            rt_kprintf("please use: addr2line -e %s -a -f", lwp->cmd);
+            rt_kprintf("please use: addr2line -e %s -a -f\n", lwp->cmd);
         }
 
         while (nesting < RT_BACKTRACE_LEVEL_MAX_NR)

diff --git a/libcpu/arm/cortex-a/backtrace.c b/libcpu/arm/cortex-a/backtrace.c
@@ -489,7 +489,7 @@ void unwind_backtrace(struct pt_regs *regs, const struct unwind_idx exidx_start[
     arm_get_current_stackframe(regs, &frame);
 
 #ifndef RT_BACKTRACE_FUNCTION_NAME
-    rt_kprintf("please use: addr2line -e rtthread.elf -a -f %08x", frame.pc);
+    rt_kprintf("please use: addr2line -e rtthread.elf -a -f %08x\n", frame.pc);
 #endif
     LOG_D("pc = %08x, sp = %08x", frame.pc, frame.sp);
 

diff --git a/libcpu/arm/cortex-r52/backtrace.c b/libcpu/arm/cortex-r52/backtrace.c
@@ -490,7 +490,7 @@ void unwind_backtrace(struct pt_regs *regs, const struct unwind_idx exidx_start[
     arm_get_current_stackframe(regs, &frame);
 
 #ifndef RT_BACKTRACE_FUNCTION_NAME
-    rt_kprintf("please use: addr2line -e rtthread.elf -a -f %08x", frame.pc);
+    rt_kprintf("please use: addr2line -e rtthread.elf -a -f %08x\n", frame.pc);
 #endif
     LOG_D("pc = %08x, sp = %08x", frame.pc, frame.sp);
 

diff --git a/src/kservice.c b/src/kservice.c
@@ -417,7 +417,7 @@ rt_weak rt_err_t rt_backtrace_frame(rt_thread_t thread, struct rt_hw_backtrace_f
 {
     long nesting = 0;
 
-    rt_kprintf("please use: addr2line -e rtthread.elf -a -f");
+    rt_kprintf("please use: addr2line -e rtthread.elf -a -f\n");
 
     while (nesting < RT_BACKTRACE_LEVEL_MAX_NR)
     {
@@ -441,7 +441,7 @@ rt_weak rt_err_t rt_backtrace_frame(rt_thread_t thread, struct rt_hw_backtrace_f
  */
 rt_weak rt_err_t rt_backtrace_formatted_print(rt_ubase_t *buffer, long buflen)
 {
-    rt_kprintf("please use: addr2line -e rtthread.elf -a -f");
+    rt_kprintf("please use: addr2line -e rtthread.elf -a -f\n");
 
     for (rt_size_t i = 0; i < buflen && buffer[i] != 0; i++)
     {