[RumbleBridge] Facelift, Validation, & Livestreams

[NotsoanoNimus]

Cleaned up some of the components of the Rumble Bridge.

• Added a distinction between All, Videos, & Live tabs on target channel pages. The 'user' option will always just show the All page in the created feed.
• Added validation of the input parameters. Not that this was a serious risk, but it's nice to be explicit.
• Fixed the NAME property displaying properly based on whether a specific account is being viewed or just the bridge card is showing.
• More accessibility (if that's even really necessary).
• Various punctuation fixes.

This change addresses Issue #4155.

Bridge card now:

Feed results look the same as they did before:

[github-actions]

Pull request artifacts

Bridge	Context	Status
Rumble	1 untitled (current)	✔️
Rumble	1 untitled (pr)	✔️

last change: Monday 2024-07-29 15:26:02

[dvikan]

[2024-07-28 22:26:08] rssbridge.DEBUG lib/BridgeCard.php(195): The "required" attribute is not supported for lists.

[dvikan]

linter being a bit annoying. sorry about that

[NotsoanoNimus]

@dvikan Oops! I removed the required label from the list type. Thank you for pointing that out.

[dvikan]

i was unable to add a commit to your branch:

commit 284158169bd7fd1a5231124e40c6f0b324f1949d (HEAD -> NotsoanoNimus/rumble-live-streams)
Author: Dag <[email protected]>
Date:   Mon Jul 29 17:05:58 2024 +0200

    lint

diff --git a/bridges/RumbleBridge.php b/bridges/RumbleBridge.php
index 636e364f..a8841e00 100644
--- a/bridges/RumbleBridge.php
+++ b/bridges/RumbleBridge.php
@@ -77,8 +77,9 @@ class RumbleBridge extends BridgeAbstract
 
     public function getName()
     {
-        return $this->getInput('account')
-            ? ('Rumble.com - ' . $this->getInput('account'))
-            : self::NAME;
+        if ($this->getInput('account')) {
+            return 'Rumble.com - ' . $this->getInput('account');
+        }
+        return self::NAME;
     }
 }

[NotsoanoNimus]

i was unable to add a commit to your branch:
. . .

I applied it. I think in my rush to publish changes I may be missing some setup with the toolchain here for debugging and checking the linter locally before pushing. I'll look into that later this evening.

[dvikan]

unintended consequence:

https://rss-bridge.org/bridge01/?action=display&bridge=RumbleBridge&account=BannonsWarRoom%2Fvideos&type=channel&format=Atom

rssbridge.ERROR Exception in DisplayAction(RumbleBridge) {
    "type": "Exception",
    "code": 0,
    "message": "Invalid target account.",
    "file": "bridges/RumbleBridge.php",
    "line": 40,
    "url": "https://rss-bridge.org/bridge01/?action=display&bridge=RumbleBridge&account=BannonsWarRoom%2Fvideos&type=channel&format=Atom",
    "trace": [
        "index.php(72): RssBridge->main()",
        "lib/RssBridge.php(103): DisplayAction->execute()",
        "actions/DisplayAction.php(65): DisplayAction->createResponse()",
        "actions/DisplayAction.php(115): RumbleBridge->collectData()",
        "bridges/RumbleBridge.php(40)"
    ]
}

[NotsoanoNimus]

If you want to explicitly view a channel's videos, you should not append a /videos onto an account name. That seems like it was a consequence of the way the bridge was initially built, allowing any characters into the Account field. Illegal URL-changing characters should not be permitted in that field.

You should instead use the channel-videos target account type to target the videos page instead: e.g., https://rss-bridge.org/bridge01/?action=display&bridge=RumbleBridge&account=BannonsWarRoom&type=channel-videos&format=Atom

[dvikan]

this is not me. im only posting logs from rss-bridge.org which I control

yes i agree with your text

[NotsoanoNimus]

this is not me. im only posting logs from rss-bridge.org which I control

yes i agree with your text

Makes sense! Apologies for the confusion, perhaps it's a regional English thing, but the 'you' here wasn't calling you out individually. It is more of a general instruction to readers who come across the writing.

[dvikan]

I detected today that this PR introduced a bug. Feed items now contain an additional forward slash in the path.

Example:

<entry>
    <title type="html">England Is Burning</title>
    <published>2024-08-12T03:30:00+00:00</published>
    <updated>2024-08-12T03:30:00+00:00</updated>
    <id>https://rumble.com//v5ae7xp-england-is-burning.html</id>
    <link rel="alternate" type="text/html" href="https://rumble.com//v5ae7xp-england-is-burning.html"/>
    <author>
      <name>[email protected]</name>
    </author>
    <co</content>
  </entry>

The Atom format defaults to using the url as id. This might cause duplicates in feed readers. But they probably trim redundant slages, im not sure.

@NotsoanoNimus