[GithubTrendingBridge] Add support for spoken languages #4149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull request artifacts
last change: Sunday 2024-07-14 15:31:17 |
dvikan
reviewed
Jul 28, 2024
| @@ -630,4 +632,32 @@ public function getName() | |||
|
|
|||
| return parent::getName(); | |||
| } | |||
|
|
|||
| private function constructUrl() | |||
There was a problem hiding this comment.
dont use empty
you might want to check out this project's Url class
NotsoanoNimus
pushed a commit
to Solstice-Software/better-rss-bridge
that referenced
this pull request
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for spoken languages through refactoring. Mentioning @liamka in case permission is needed for the changes.